Mholloway has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373146 )
Change subject: Log HTTP error status codes for page save failures
......................................................................
Log HTTP error status codes for page save failures
We are attempting to log errors when saving pages in HockeyApp in attempt
to debug remaining page save issues, but the logged errors currently
contain no useful information; the most we can deduce is that the server
returned an error response code. This updates the logged exceptions to
include logging the actual response code.
Change-Id: I9f45f887c01245a7fa26b128268c7623339682f1
---
M app/src/main/java/org/wikipedia/dataclient/okhttp/HttpStatusException.java
M app/src/main/java/org/wikipedia/savedpages/SavedPageSyncService.java
2 files changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/46/373146/1
diff --git
a/app/src/main/java/org/wikipedia/dataclient/okhttp/HttpStatusException.java
b/app/src/main/java/org/wikipedia/dataclient/okhttp/HttpStatusException.java
index 36c5ee0..1315978 100644
--- a/app/src/main/java/org/wikipedia/dataclient/okhttp/HttpStatusException.java
+++ b/app/src/main/java/org/wikipedia/dataclient/okhttp/HttpStatusException.java
@@ -2,6 +2,8 @@
import android.support.annotation.NonNull;
+import org.wikipedia.crash.RemoteLogException;
+
import java.io.IOException;
import okhttp3.Response;
@@ -16,4 +18,8 @@
public int code() {
return code;
}
+
+ public static RemoteLogException toRemoteLogException(@NonNull
HttpStatusException e) {
+ return new RemoteLogException(Integer.toString(e.code()), e);
+ }
}
diff --git
a/app/src/main/java/org/wikipedia/savedpages/SavedPageSyncService.java
b/app/src/main/java/org/wikipedia/savedpages/SavedPageSyncService.java
index c4ab2bb..c8aa581 100644
--- a/app/src/main/java/org/wikipedia/savedpages/SavedPageSyncService.java
+++ b/app/src/main/java/org/wikipedia/savedpages/SavedPageSyncService.java
@@ -7,8 +7,10 @@
import android.text.TextUtils;
import org.wikipedia.WikipediaApp;
+import org.wikipedia.crash.RemoteLogException;
import org.wikipedia.database.contract.PageImageHistoryContract;
import org.wikipedia.dataclient.WikiSite;
+import org.wikipedia.dataclient.okhttp.HttpStatusException;
import org.wikipedia.dataclient.okhttp.OkHttpConnectionFactory;
import org.wikipedia.dataclient.okhttp.cache.DiskLruCacheUtil;
import org.wikipedia.dataclient.okhttp.cache.SaveHeader;
@@ -145,7 +147,11 @@
if (!ThrowableUtil.isOffline(e)) {
// If it's anything but a transient network error, let's
log it aggressively,
// to make sure we've fixed any other errors with saving
pages.
- L.logRemoteError(e);
+ if (e instanceof HttpStatusException) {
+
L.logRemoteError(HttpStatusException.toRemoteLogException((HttpStatusException)
e));
+ } else {
+ L.logRemoteError(e);
+ }
}
dao.failDiskTransaction(row);
continue;
--
To view, visit https://gerrit.wikimedia.org/r/373146
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f45f887c01245a7fa26b128268c7623339682f1
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
