jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/373225 )
Change subject: Prevent adding more globals in the new test suite
......................................................................
Prevent adding more globals in the new test suite
Change-Id: I4516dbd6423277ae36fe55c5507045b132ea05dd
---
A tests/jasmine/.eslintrc.json
M tests/jasmine/GlossWidget.spec.js
M tests/jasmine/LemmaWidget.spec.js
3 files changed, 10 insertions(+), 3 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/jasmine/.eslintrc.json b/tests/jasmine/.eslintrc.json
new file mode 100644
index 0000000..4da00ac
--- /dev/null
+++ b/tests/jasmine/.eslintrc.json
@@ -0,0 +1,7 @@
+{
+ "environment": ["shared-node-browser", "jasmine"],
+ "rules": {
+ "no-global-assign": 2,
+ "no-restricted-globals": [2, "global"]
+ }
+}
diff --git a/tests/jasmine/GlossWidget.spec.js
b/tests/jasmine/GlossWidget.spec.js
index d175dff..44e7652 100644
--- a/tests/jasmine/GlossWidget.spec.js
+++ b/tests/jasmine/GlossWidget.spec.js
@@ -16,7 +16,7 @@
var expect = require( 'unexpected' ).clone();
expect.installPlugin( require( 'unexpected-dom' ) );
- var Vue = global.Vue = require( 'vue/dist/vue.js' );
+ var Vue = global.Vue = require( 'vue/dist/vue.js' ); //
eslint-disable-line no-restricted-globals
var GlossWidget = require( 'wikibase.lexeme.widgets.GlossWidget' );
it(
diff --git a/tests/jasmine/LemmaWidget.spec.js
b/tests/jasmine/LemmaWidget.spec.js
index 044e3d8..77a4127 100644
--- a/tests/jasmine/LemmaWidget.spec.js
+++ b/tests/jasmine/LemmaWidget.spec.js
@@ -6,8 +6,8 @@
var expect = require( 'unexpected' ).clone();
expect.installPlugin( require( 'unexpected-dom' ) );
- var Vue = global.Vue = require( 'vue/dist/vue.js' );
- var Vuex = global.Vuex = require( 'vuex/dist/vuex.js' );
+ var Vue = global.Vue = require( 'vue/dist/vue.js' ); //
eslint-disable-line no-restricted-globals
+ var Vuex = global.Vuex = require( 'vuex/dist/vuex.js' ); //
eslint-disable-line no-restricted-globals
Vue.use( Vuex );
var newLemmaWidget = require(
'wikibase.lexeme.widgets.LemmaWidget.newLemmaWidget' );
--
To view, visit https://gerrit.wikimedia.org/r/373225
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4516dbd6423277ae36fe55c5507045b132ea05dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Chrisneuroth <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
