ItSpiderman has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373263 )
Change subject: Statistics: Fix for column label and dataIndex
......................................................................
Statistics: Fix for column label and dataIndex
In statistic tables data index is derived from field label ( message key
).
Its normalized (lowecased, spaces replaced with _), but there was a case
where label contained a period, which is also not allowed, breaking that
columns values.
Change-Id: I07a2e47ed8f23151ffef275650555da2064ee40f
ERM: #7260
---
M Statistics/includes/api/BSApiStatisticsTasks.php
1 file changed, 1 insertion(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions
refs/changes/63/373263/1
diff --git a/Statistics/includes/api/BSApiStatisticsTasks.php
b/Statistics/includes/api/BSApiStatisticsTasks.php
index a47c73c..1094a1a 100644
--- a/Statistics/includes/api/BSApiStatisticsTasks.php
+++ b/Statistics/includes/api/BSApiStatisticsTasks.php
@@ -176,6 +176,7 @@
foreach( $aLabels as $sLabel ) {
$sField = strtolower( $sLabel );
$sField = str_replace( " ", "_", $sField );
+ $sField = str_replace( ".", "", $sField );
$aFields[] = array( 'name' => $sField );
$aColumns[] = array( 'header' => $sLabel,
'dataIndex' => $sField );
}
--
To view, visit https://gerrit.wikimedia.org/r/373263
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07a2e47ed8f23151ffef275650555da2064ee40f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: ItSpiderman <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
