Jcrespo has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/373267 )

Change subject: mariadb: Renable buffer pool dump on dbstores and prometheus fix
......................................................................

mariadb: Renable buffer pool dump on dbstores and prometheus fix

Buffer pool dumping and loading was removed due to them being used
for dumps. Keeping it may be better than nothing on restart.

Remove s1 and s4 at dbstore2001 from prometheus, as they no longer
are on that host.

Bug: T168409
Change-Id: Ic7a0fce36ddd4cdd13bae15cf318276364f14c3a
---
M modules/role/files/prometheus/mysql-dbstore_codfw.yaml
M modules/role/templates/mariadb/mysqld_config/dbstore_multiinstance.my.cnf.erb
2 files changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/67/373267/1

diff --git a/modules/role/files/prometheus/mysql-dbstore_codfw.yaml 
b/modules/role/files/prometheus/mysql-dbstore_codfw.yaml
index 5fdf013..899ff67 100644
--- a/modules/role/files/prometheus/mysql-dbstore_codfw.yaml
+++ b/modules/role/files/prometheus/mysql-dbstore_codfw.yaml
@@ -2,7 +2,6 @@
     shard: s1
     role: slave
   targets:
-  - dbstore2001:13311
   - dbstore2002:13311
 
 - labels:
@@ -23,7 +22,6 @@
     shard: s4
     role: slave
   targets:
-  - dbstore2001:13314
   - dbstore2002:13314
 
 - labels:
diff --git 
a/modules/role/templates/mariadb/mysqld_config/dbstore_multiinstance.my.cnf.erb 
b/modules/role/templates/mariadb/mysqld_config/dbstore_multiinstance.my.cnf.erb
index 4836e3c..d6a9114 100644
--- 
a/modules/role/templates/mariadb/mysqld_config/dbstore_multiinstance.my.cnf.erb
+++ 
b/modules/role/templates/mariadb/mysqld_config/dbstore_multiinstance.my.cnf.erb
@@ -59,8 +59,9 @@
 
 # don't dump and load innodb buffer at start and stop
 # these servers will have the buffer pool in a bad state due to dumps
-innodb_buffer_pool_load_at_startup  = 0
-innodb_buffer_pool_dump_at_shutdown = 0
+# so not sure if these will be useful, but we leave them here for now
+innodb_buffer_pool_load_at_startup  = 1
+innodb_buffer_pool_dump_at_shutdown = 1
 
 optimizer_switch='engine_condition_pushdown=on,optimize_join_buffer_size=on'
 join_cache_level = 8

-- 
To view, visit https://gerrit.wikimedia.org/r/373267
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7a0fce36ddd4cdd13bae15cf318276364f14c3a
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Jcrespo <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to