jenkins-bot has submitted this change and it was merged.
Change subject: Remove error suppression from Parser::formatHeadings
......................................................................
Remove error suppression from Parser::formatHeadings
The array index looks always initialized
Change-Id: I63a1c264ded0c4a744ee990de9bef4f8f9d20d1d
---
M includes/parser/Parser.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
IAlex: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php
index 7f21449..99042ae 100644
--- a/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@ -4158,7 +4158,7 @@
$levelCount[$toclevel] = $level;
# count number of headlines for each level
- @$sublevelCount[$toclevel]++;
+ $sublevelCount[$toclevel]++;
$dot = 0;
for( $i = 1; $i <= $toclevel; $i++ ) {
if ( !empty( $sublevelCount[$i] ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/54214
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63a1c264ded0c4a744ee990de9bef4f8f9d20d1d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Daniel Friesen <[email protected]>
Gerrit-Reviewer: IAlex <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
