jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/373264 )

Change subject: pagePreviews: Enable A/B test (BC-only)
......................................................................


pagePreviews: Enable A/B test (BC-only)

Enable anonymous user bucket on all wikis but only enable the
EventLogging instrumentation on enwiki (so that we can prove that the
kill switch works).

Supporting changes:
* Ensure that BC-only config overrides production config where
  necessary.
* Remove wgPopupsSchemaSamplingRate and wgPopupsAnonsEnabledSamplingRate
  configuration variables.

Bug: T171853
Change-Id: I85c3fcfdbca8b0d634995f95a93bacf72248eb9d
---
M wmf-config/InitialiseSettings-labs.php
1 file changed, 25 insertions(+), 15 deletions(-)

Approvals:
  Niharika29: Looks good to me, approved
  Jhernandez: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/wmf-config/InitialiseSettings-labs.php 
b/wmf-config/InitialiseSettings-labs.php
index c20bd91..1b394c2 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -553,19 +553,6 @@
                        'default' => true,
                ],
 
-               // T165018: Make Page Previews (Popups) use RESTBase's page 
summary endpoint
-               // and consume the HTML returned.
-               'wgPopupsGateway' => [
-                       'default' => 'restbaseHTML',
-               ],
-
-               // To allow us to test EventLogging in the beta cluster we log 
all events
-               'wgPopupsSchemaSamplingRate' => [
-                       'default' => 1,
-               ],
-               'wgPopupsStatsvSamplingRate' => [
-                       'default' => 1,
-               ],
                'wgEnableRcFiltersBetaFeature' => [
                        'default' => true,
                ],
@@ -577,10 +564,33 @@
                'wmgUsePopups' => [
                        'default' => true,
                ],
-               'wmgPopupsBetaFeature' => [
+
+               '-wmgPopupsBetaFeature' => [
                        'default' => false,
                ],
-               'wgPopupsAnonsEnabledSamplingRate' => [
+
+               // T171853: For 25% of anonymous user sessions, Page Previews 
will be
+               // enabled by default as well as the instrumentation; for 25%, 
PP will be
+               // disabled by default; for 50%, PP will be disabled as will the
+               // instrumentation.
+               '-wgPopupsAnonsExperimentalGroupSize' => [
+                       'default' => 0.25,
+               ],
+
+               // T171853: Enable PP EventLogging instrumentation on enwiki 
only so that we
+               // can prove the killswitch works.
+               '-wgPopupsEventLogging' => [
+                       'default' => false,
+                       'enwiki' => true,
+               ],
+
+               // T165018: Make Page Previews (Popups) use RESTBase's page 
summary endpoint
+               // and consume the HTML returned.
+               '-wgPopupsGateway' => [
+                       'default' => 'restbaseHTML',
+               ],
+
+               '-wgPopupsStatsvSamplingRate' => [
                        'default' => 1,
                ],
 

-- 
To view, visit https://gerrit.wikimedia.org/r/373264
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I85c3fcfdbca8b0d634995f95a93bacf72248eb9d
Gerrit-PatchSet: 5
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Niharika29 <[email protected]>
Gerrit-Reviewer: Urbanecm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to