jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/373374 )
Change subject: Do not record failures for non-existent accounts
......................................................................
Do not record failures for non-existent accounts
Change-Id: I2229f76aa6de0933cd11c6516f0486816f173533
---
M includes/LoginNotify.php
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/LoginNotify.php b/includes/LoginNotify.php
index df8217a..306aa89 100644
--- a/includes/LoginNotify.php
+++ b/includes/LoginNotify.php
@@ -735,6 +735,16 @@
*/
public function recordFailure( User $user ) {
$this->incrStats( 'fail.total' );
+
+ if ( $user->isAnon() ) {
+ // Login failed because user doesn't exist
+ // skip this user.
+ $this->log->debug( "Skipping recording failure for
{user} - no account",
+ [ 'user' => $user->getName() ]
+ );
+ return;
+ }
+
$known = $this->isKnownSystemFast( $user, $user->getRequest() );
if ( $known === self::USER_KNOWN ) {
$this->recordLoginFailureFromKnownSystem( $user );
--
To view, visit https://gerrit.wikimedia.org/r/373374
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2229f76aa6de0933cd11c6516f0486816f173533
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/LoginNotify
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff <bawolff...@gmail.com>
Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
