Kaartic has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373629 )
Change subject: Onboarding: give some space between buttons and screen
......................................................................
Onboarding: give some space between buttons and screen
Keeping the buttons close to the end of the screen makes it
harder to access them.
So, give some space between the button and the screen borders.
Change-Id: If7b453463aa440e7b5d5c93c74f2c9b044b1cd65
Credits: Google slides
---
M app/src/main/res/layout/fragment_onboarding_pager.xml
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/29/373629/1
diff --git a/app/src/main/res/layout/fragment_onboarding_pager.xml
b/app/src/main/res/layout/fragment_onboarding_pager.xml
index dc5bdce..ea18dbd 100644
--- a/app/src/main/res/layout/fragment_onboarding_pager.xml
+++ b/app/src/main/res/layout/fragment_onboarding_pager.xml
@@ -28,7 +28,8 @@
style="@style/Widget.AppCompat.Button.Borderless"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:layout_margin="0dp"
+ android:layout_marginLeft="16dp"
+ android:layout_marginStart="16dp"
android:text="@string/onboarding_skip"
android:textColor="@android:color/white" />
@@ -55,6 +56,8 @@
app:srcCompat="@drawable/ic_chevron_forward_white_24dp"
android:scaleType="center"
android:clickable="true"
+ android:layout_marginRight="16dp"
+ android:layout_marginEnd="16dp"
android:background="?attr/selectableItemBackgroundBorderless"
android:contentDescription="@string/onboarding_continue"/>
@@ -63,7 +66,8 @@
style="@style/Widget.AppCompat.Button.Borderless"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:layout_margin="0dp"
+ android:layout_marginRight="8dp"
+ android:layout_marginEnd="8dp"
android:text="@string/onboarding_get_started"
android:textColor="@android:color/white" />
--
To view, visit https://gerrit.wikimedia.org/r/373629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If7b453463aa440e7b5d5c93c74f2c9b044b1cd65
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Kaartic <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
