Sbisson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373679 )
Change subject: RCFilters: Enable 'View newest'
......................................................................
RCFilters: Enable 'View newest'
Keep the feature flag for 'live update'
but enable 'view newest' by default on RC.
Bug: T163426
Change-Id: I733cf99bbeb6d90d3aa21e87507c513354b81791
---
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.ChangesListViewModel.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
M
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FormWrapperWidget.js
4 files changed, 8 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/79/373679/1
diff --git
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.ChangesListViewModel.js
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.ChangesListViewModel.js
index d7042ff..0155a58 100644
---
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.ChangesListViewModel.js
+++
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.ChangesListViewModel.js
@@ -79,9 +79,7 @@
mw.rcfilters.dm.ChangesListViewModel.prototype.update = function (
changesListContent, $fieldset, isInitialDOM, separateOldAndNew ) {
var from = this.nextFrom;
this.valid = true;
- if ( mw.rcfilters.featureFlags.liveUpdate ) {
- this.extractNextFrom( $fieldset );
- }
+ this.extractNextFrom( $fieldset );
this.checkForUnseenWatchedChanges( changesListContent );
this.emit( 'update', changesListContent, $fieldset,
isInitialDOM, separateOldAndNew ? from : null );
};
@@ -112,7 +110,8 @@
* @param {jQuery} $fieldset
*/
mw.rcfilters.dm.ChangesListViewModel.prototype.extractNextFrom =
function ( $fieldset ) {
- this.nextFrom = $fieldset.find( '.rclistfrom > a' ).data(
'params' ).from;
+ var data = $fieldset.find( '.rclistfrom > a' ).data( 'params' );
+ this.nextFrom = data ? data.from : null;
};
/**
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
index 9906119..a0e60d5 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
@@ -550,7 +550,7 @@
!this.filtersModel.hasConflict() &&
!this.changesListModel.getNewChangesExist() &&
!this.updatingChangesList &&
- mw.rcfilters.featureFlags.liveUpdate;
+ this.changesListModel.getNextFrom();
};
/**
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
index 955e01d..a97ffe9 100644
---
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
+++
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesListWrapperWidget.js
@@ -48,9 +48,7 @@
// Set up highlight containers
this.setupHighlightContainers( this.$element );
- if ( mw.rcfilters.featureFlags.liveUpdate ) {
- this.setupNewChangesButtonContainer( this.$element );
- }
+ this.setupNewChangesButtonContainer( this.$element );
};
/* Initialization */
diff --git
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FormWrapperWidget.js
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FormWrapperWidget.js
index 5a64edd..ad99e22 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FormWrapperWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FormWrapperWidget.js
@@ -153,11 +153,9 @@
this.$element.find( '.cloption-submit' ).detach();
}
- if ( mw.rcfilters.featureFlags.liveUpdate ) {
- this.$element.find(
- '.rclistfrom, .rcnotefrom,
.rcoptions-listfromreset'
- ).detach();
- }
+ this.$element.find(
+ '.rclistfrom, .rcnotefrom, .rcoptions-listfromreset'
+ ).detach();
if ( this.$element.text().trim() === this.$element.find(
'legend' ).text() ) {
this.$element.detach();
--
To view, visit https://gerrit.wikimedia.org/r/373679
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I733cf99bbeb6d90d3aa21e87507c513354b81791
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Sbisson <sbis...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
