jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370855 )

Change subject: Disable Ogg Theora video transcodes in default config
......................................................................


Disable Ogg Theora video transcodes in default config

With WebM playback enabled via ogv.js, there's less reason to keep
the Ogg Theora video transcodes on Wikimedia or other sites.
Removing them by default in favor of just generating WebM.

This speeds encoding time and saves disk space, at the cost of
the WebM videos requiring more CPU in Safari/IE/Edge with the ogv.js
player shim.

Prep for removing them from Wikimedia due to ongoing tooling issues
with ffmpeg2theora.

Safe to merge after I68f22d7c goes out fully.

Bug: T172445
Change-Id: I2ffd2c6d0f87c53c0addc69515fdad803e192199
---
M TimedMediaHandler.php
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Brion VIBBER: Looks good to me, approved
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/TimedMediaHandler.php b/TimedMediaHandler.php
index 80ac0ee..0cade78 100644
--- a/TimedMediaHandler.php
+++ b/TimedMediaHandler.php
@@ -135,7 +135,8 @@
 
        // WebM VP8/Vorbis
        // primary free/open video format
-       // supported by Chrome/Firefox/Opera but not Safari/IE/Edge
+       // supported by Chrome/Firefox/Opera natively
+       // plays back in Safari/IE/Edge via ogv.js
 
        // Very low-bitrate web streamable WebM video
        WebVideoTranscode::ENC_WEBM_160P,
@@ -158,8 +159,10 @@
        // A 4K full high quality WebM stream
        // WebVideoTranscode::ENC_WEBM_2160P,
 
+/*
        // Ogg Theora/Vorbis
-       // Fallback for Safari/IE/Edge with ogv.js
+       // Optional fallback for Safari/IE/Edge with ogv.js
+       // Faster to encode & play back than WebM but less efficient.
 
        // Requires twice the bitrate for same quality as VP8,
        // and JS decoder can be slow, so shift to smaller sizes.
@@ -183,6 +186,7 @@
        // Variable-bitrate HD Ogg stream
        // for ogv.js on reasonably speedy machines
        WebVideoTranscode::ENC_OGV_1080P,
+*/
 
 /*
        // MP4 H.264/AAC

-- 
To view, visit https://gerrit.wikimedia.org/r/370855
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2ffd2c6d0f87c53c0addc69515fdad803e192199
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to