Pcoombe has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373704 )
Change subject: Don't select a submethod if there are errors in personal info ...................................................................... Don't select a submethod if there are errors in personal info If there are errors in the personal info fields and the user tries to select a submethod, do nothing other than highlight the errors. This removes the confusing situation where there could be two continue buttons on screen (from this, and from the iframe). Bug: T149366 Change-Id: If7405408659f588e506179781ed7ab5874c0a04a --- M modules/js/ext.donationInterface.forms.js 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface refs/changes/04/373704/1 diff --git a/modules/js/ext.donationInterface.forms.js b/modules/js/ext.donationInterface.forms.js index 5b72dd3..edd1d43 100644 --- a/modules/js/ext.donationInterface.forms.js +++ b/modules/js/ext.donationInterface.forms.js @@ -129,12 +129,12 @@ $( '#paymentContinue' ).show(); } - // Submit on submethod click if valid, otherwise show continue button. + // Submit on submethod click if valid, otherwise do nothing. $( 'input[name="payment_submethod"]' ).on( 'click', function () { if ( di.validation.validate() ) { di.forms.submit(); } else { - $( '#paymentContinue' ).show(); + return false; } } ); -- To view, visit https://gerrit.wikimedia.org/r/373704 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If7405408659f588e506179781ed7ab5874c0a04a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Pcoombe <pcoo...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits