[MediaWiki-commits] [Gerrit] wikidata...rdf[master]: allow unit tests to override store props

[Yurik (Code Review)]

Yurik has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/373725 )

Change subject: allow unit tests to override store props
......................................................................

allow unit tests to override store props

Change-Id: I21219c91bf475b6721a5254f79f91c23b1c7992c
---
M 
blazegraph/src/test/java/org/wikidata/query/rdf/blazegraph/AbstractRandomizedBlazegraphStorageTestCase.java
1 file changed, 13 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/rdf 
refs/changes/25/373725/1

diff --git 
a/blazegraph/src/test/java/org/wikidata/query/rdf/blazegraph/AbstractRandomizedBlazegraphStorageTestCase.java
 
b/blazegraph/src/test/java/org/wikidata/query/rdf/blazegraph/AbstractRandomizedBlazegraphStorageTestCase.java
index 230d7f4..77d01f6 100644
--- 
a/blazegraph/src/test/java/org/wikidata/query/rdf/blazegraph/AbstractRandomizedBlazegraphStorageTestCase.java
+++ 
b/blazegraph/src/test/java/org/wikidata/query/rdf/blazegraph/AbstractRandomizedBlazegraphStorageTestCase.java
@@ -75,7 +75,17 @@
         if (store != null) {
             return store;
         }
-        Properties properties = new Properties();
+        store = new TempTripleStore(temporaryStore(), initStoreProperties(new 
Properties()), null);
+        return store;
+    }
+
+    /**
+     * Initialize store properties.
+     * Allows property override by either updating properties object, or 
returning a new one.
+     * @param properties Properties that have been set so far
+     * @return Properties object after updating it
+     */
+    protected Properties initStoreProperties(Properties properties) {
         
properties.setProperty("com.bigdata.rdf.store.AbstractTripleStore.vocabularyClass",
                 WikibaseVocabulary.VOCABULARY_CLASS.getName());
         
properties.setProperty("com.bigdata.rdf.store.AbstractTripleStore.inlineURIFactory",
@@ -94,8 +104,8 @@
                         + "{ \"valueType\": \"DOUBLE\", \"multiplier\": 
\"1000000000\", \"serviceMapping\": \"LATITUDE\" }, "
                         + "{ \"valueType\": \"LONG\", 
\"multiplier\":\"1\",\"minValue\":\"0\", \"serviceMapping\": \"COORD_SYSTEM\" } 
"
                         + "]}}");
-        store = new TempTripleStore(temporaryStore(), properties, null);
-        return store;
+
+        return properties;
     }
 
     /**

-- 
To view, visit https://gerrit.wikimedia.org/r/373725
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I21219c91bf475b6721a5254f79f91c23b1c7992c
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Yurik <yuriastrak...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits