Muehlenhoff has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/373789 )
Change subject: Review feedback by Riccardo
......................................................................
Review feedback by Riccardo
Change-Id: Iabae56a96d0909a9b6e881046bc4ca579419e248
---
M clients/debdeploy-revdeps
1 file changed, 8 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/debs/debdeploy
refs/changes/89/373789/1
diff --git a/clients/debdeploy-revdeps b/clients/debdeploy-revdeps
index f6f30b5..b32a12b 100755
--- a/clients/debdeploy-revdeps
+++ b/clients/debdeploy-revdeps
@@ -1,14 +1,13 @@
-#! /usr/bin/python
+#!/usr/bin/python
# -*- coding: utf-8 -*-
'''
Module for querying installed reverse dependencies of a package
'''
-import subprocess
-import os
-import sys
import argparse
import json
+import subprocess
+import sys
def parse_args():
@@ -16,7 +15,7 @@
description='debdeploy-revdeps - Query for installed reverse
dependencies')
p.add_argument('--json', action='store_true', default=False,
help='Return results as JSON')
- p.add_argument('--package', action='store', nargs='+', required=True)
+ p.add_argument('packages', action='store', nargs='+')
args = p.parse_args(sys.argv[1:])
@@ -40,9 +39,9 @@
args = parse_args()
try:
- rev_deps = subprocess.check_output(['apt-cache', '--installed',
'rdepends'] + args.package)
+ rev_deps = subprocess.check_output(['apt-cache', '--installed',
'rdepends'] + args.packages)
except subprocess.CalledProcessError as e:
- logger.info('Failed to query reverse dependies', e.returncode)
+ print 'Failed to query reverse dependies', e.returncode
return result('ERROR Failed to query dependencies', '')
deps = set()
@@ -50,14 +49,14 @@
for i in rev_deps.split():
if i.startswith("|"): # denotes an alternate dependency
deps.add(i.strip()[1:])
- elif i in args.package: # apt-cache rdepends also prints the package
name
+ elif i in args.packages: # apt-cache rdepends also prints the package
name
continue
elif i in ['Depends:', 'Reverse']: # output by apt-cache
continue
else:
deps.add(i.strip())
- return result('OK', list(sorted(deps)))
+ return result('OK', sorted(deps))
if __name__ == '__main__':
--
To view, visit https://gerrit.wikimedia.org/r/373789
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabae56a96d0909a9b6e881046bc4ca579419e248
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/debdeploy
Gerrit-Branch: master
Gerrit-Owner: Muehlenhoff <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
