Jhernandez has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/373723 )
Change subject: Chore: use TypeScript for types instead of JSDocs
......................................................................
Chore: use TypeScript for types instead of JSDocs
JSDocs may become outdated so don't require them to specify typing.
Change-Id: I7f0f44671addbd9fb3d24cef49d423a1504964f0
---
M .eslintrc.json
M src/server/templates/page.ts
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Jhernandez: Verified; Looks good to me, approved
diff --git a/.eslintrc.json b/.eslintrc.json
index 7cb9105..25c8bbd 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -34,6 +34,9 @@
{
"files": [ "*.ts", "*.tsx" ],
"rules": {
+ // Unnecessary for a typed language.
+ "jsdoc/require-returns-type": 0,
+
// Disable rules with known issues.
// https://github.com/eslint/typescript-eslint-parser#known-issues
"no-undef": 0,
diff --git a/src/server/templates/page.ts b/src/server/templates/page.ts
index 7f3e8c2..8f86db1 100644
--- a/src/server/templates/page.ts
+++ b/src/server/templates/page.ts
@@ -10,9 +10,9 @@
}
/**
- * @return {!string} The path to the asset identified by entry and extension
- * (e.g., index.js); either a URL (development) or a
- * filesystem path (production).
+ * @return The path to the asset identified by entry and extension (e.g.,
+ * index.js); either a URL (development) or a filesystem path
+ * (production).
*/
const asset = (assets: Assets | string, entry: string, extension: string) =>
typeof assets === "string"
--
To view, visit https://gerrit.wikimedia.org/r/373723
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f0f44671addbd9fb3d24cef49d423a1504964f0
Gerrit-PatchSet: 2
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
