jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/373712 )
Change subject: Fix error text color in dark mode
......................................................................
Fix error text color in dark mode
In this update
- Add Red75-Sunset Red to colors.xml
- Add two "textColorError" items for light mode and dark mode theme
Bug: T173091
Change-Id: I3d5030f4fe173e0e50904a5ec771e876082a5e57
---
M app/src/main/res/values/colors.xml
M app/src/main/res/values/styles.xml
M app/src/main/res/values/styles_dark.xml
M app/src/main/res/values/styles_light.xml
4 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/res/values/colors.xml
b/app/src/main/res/values/colors.xml
index 07b569f..9072c79 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -22,6 +22,7 @@
<color name="accent30">#2a4b8d</color> <!-- W AAA: Active buttons, Active
links -->
<color name="accent20">#223966</color>
<color name="red90">#fee7e6</color> <!-- B AAA -->
+ <color name="red75">#FF6E6E</color> <!-- Destructive text (error messages,
red links) -->
<color name="red50">#d33</color> <!-- B&W AA Destructive: Destructive
actions, Buttons and links, Alerts -->
<color name="red30">#b32424</color> <!-- W AAA: Destructive active buttons
and links -->
diff --git a/app/src/main/res/values/styles.xml
b/app/src/main/res/values/styles.xml
index fa75205..769a58f 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -255,4 +255,5 @@
<item
name="android:dropDownHorizontalOffset">@dimen/popup_menu_drop_down_horizontal_offset</item>
<item
name="android:dropDownVerticalOffset">@dimen/popup_menu_drop_down_vertical_offset</item>
</style>
+
</resources>
diff --git a/app/src/main/res/values/styles_dark.xml
b/app/src/main/res/values/styles_dark.xml
index c519670..2b1906b 100644
--- a/app/src/main/res/values/styles_dark.xml
+++ b/app/src/main/res/values/styles_dark.xml
@@ -15,6 +15,7 @@
<style name="Theme.Dark" parent="Theme.AppCompat.NoActionBar">
<item name="colorPrimary">@color/accent75</item>
+ <item name="textColorError">@color/red75</item>
<item name="windowActionModeOverlay">true</item>
<item name="drawerArrowStyle">@style/AppTheme.DrawerArrowStyle</item>
<item name="actionMenuTextColor">@android:color/white</item>
diff --git a/app/src/main/res/values/styles_light.xml
b/app/src/main/res/values/styles_light.xml
index a219cd4..e842397 100644
--- a/app/src/main/res/values/styles_light.xml
+++ b/app/src/main/res/values/styles_light.xml
@@ -15,6 +15,7 @@
<style name="Theme.Light" parent="Theme.AppCompat.Light.NoActionBar">
<item name="colorPrimary">@color/accent50</item>
+ <item name="textColorError">@color/red50</item>
<item name="windowActionModeOverlay">true</item>
<item name="drawerArrowStyle">@style/AppTheme.DrawerArrowStyle</item>
<item name="actionMenuTextColor">@android:color/white</item>
--
To view, visit https://gerrit.wikimedia.org/r/373712
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d5030f4fe173e0e50904a5ec771e876082a5e57
Gerrit-PatchSet: 3
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Cooltey <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Sharvaniharan <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
