Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373986 )
Change subject: Dark Mode : Change card colors for dark mode ...................................................................... Dark Mode : Change card colors for dark mode - Changed Search bar style to a custom search background of base12 [ Exosphere Gray] instead of the android defined 'selectable items gray' - Changed CardView backgrounds to base14 [Thermosphere Gray] instead of default material standard of #424242 for dark mode. Light mode is still material default. - Found background to be base10 [Darkest Gray] as required. No changes to that. Screenshots for change : https://drive.google.com/open?id=0B_maM54cPModWkNGY1E5dmZXdms Bug : T173302 Change-Id: If8c21e6b3375163a7bf06057aac3254345e10135 --- M app/src/main/res/layout/view_search_bar.xml M app/src/main/res/values/attrs.xml M app/src/main/res/values/styles_dark.xml M app/src/main/res/values/styles_light.xml 4 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/86/373986/1 diff --git a/app/src/main/res/layout/view_search_bar.xml b/app/src/main/res/layout/view_search_bar.xml index a2f4288..b7c1843 100644 --- a/app/src/main/res/layout/view_search_bar.xml +++ b/app/src/main/res/layout/view_search_bar.xml @@ -4,7 +4,7 @@ android:id="@+id/search_container" android:layout_width="match_parent" android:layout_height="wrap_content" - android:background="?attr/selectableItemBackground" + android:background="?attr/searchItemBackground" android:clickable="true"> <ImageView diff --git a/app/src/main/res/values/attrs.xml b/app/src/main/res/values/attrs.xml index 15084fa..f68826f 100644 --- a/app/src/main/res/values/attrs.xml +++ b/app/src/main/res/values/attrs.xml @@ -41,6 +41,8 @@ <attr name="overflow_button" format="reference" /> <attr name="multi_select_background_color" format="reference" /> + <attr name="searchItemBackground" format="reference" /> + <attr name="cardBackgroundColor" format="color" /> <declare-styleable name="CabSearchView"> <attr name="cabEnabled" format="boolean" /> diff --git a/app/src/main/res/values/styles_dark.xml b/app/src/main/res/values/styles_dark.xml index 2b1906b..072eeca 100644 --- a/app/src/main/res/values/styles_dark.xml +++ b/app/src/main/res/values/styles_dark.xml @@ -74,6 +74,8 @@ <item name="feed_text_primary_color">@color/feed_text_primary_dark</item> <item name="feed_text_secondary_color">@color/feed_text_secondary_dark</item> <item name="feed_text_tertiary_color">@color/feed_text_tertiary_dark</item> + <item name="searchItemBackground">@color/base12</item> + <item name="cardBackgroundColor">@color/base14</item> </style> <style name="Theme.Dark.Dialog.Alert" parent="Theme.AppCompat.Dialog.Alert"> diff --git a/app/src/main/res/values/styles_light.xml b/app/src/main/res/values/styles_light.xml index e842397..39b8c8a 100644 --- a/app/src/main/res/values/styles_light.xml +++ b/app/src/main/res/values/styles_light.xml @@ -74,6 +74,7 @@ <item name="feed_text_primary_color">@color/feed_text_primary_light</item> <item name="feed_text_secondary_color">@color/feed_text_secondary_light</item> <item name="feed_text_tertiary_color">@color/feed_text_tertiary_light</item> + <item name="searchItemBackground">@color/base100</item> </style> <style name="Theme.Light.Dialog.Alert" parent="Theme.AppCompat.Light.Dialog.Alert"> -- To view, visit https://gerrit.wikimedia.org/r/373986 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If8c21e6b3375163a7bf06057aac3254345e10135 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Sharvaniharan <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
