MarkAHershberger has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374039 )
Change subject: "PHP Warning: XMLReader::open(): Unable to open source data" on
JPG data
......................................................................
"PHP Warning: XMLReader::open(): Unable to open source data" on JPG data
MimeAnalyzer::doGuessMimeType() uses XmlTypeCheck to find the type of
a file. When the file does not contain XML data (e.g JPEG data) the
following is emitted:
PHP Warning: XMLReader::open(): Unable to open source data
suppressWarnings() should be used or the getimagesize() check should be done
earlier.
Bug: T174254
Change-Id: I2d4f1991490c6989e54527c03dd9146e87e175a0
---
M includes/libs/mime/MimeAnalyzer.php
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/39/374039/1
diff --git a/includes/libs/mime/MimeAnalyzer.php
b/includes/libs/mime/MimeAnalyzer.php
index 5f4d7c9..8621f43 100644
--- a/includes/libs/mime/MimeAnalyzer.php
+++ b/includes/libs/mime/MimeAnalyzer.php
@@ -743,7 +743,9 @@
/**
* look for XML formats (XHTML and SVG)
*/
+ MediaWiki\suppressWarnings();
$xml = new XmlTypeCheck( $file );
+ MediaWiki\restoreWarnings();
if ( $xml->wellFormed ) {
$xmlTypes = $this->xmlTypes;
if ( isset( $xmlTypes[$xml->getRootElement()] ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/374039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d4f1991490c6989e54527c03dd9146e87e175a0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_28
Gerrit-Owner: MarkAHershberger <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
