jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/374075 )

Change subject: Fix dependencies to core modules
......................................................................


Fix dependencies to core modules

Add dependency on module 'mediawiki.util' for module
'ext.RevisionSlider.DiffPage' because
modules/ext.RevisionSlider.DiffPage.js uses mw.util.wikiScript.

Remove dependency on module 'mediawiki.util' for module
'ext.RevisionSlider.RevisionList' because this module does not use any
functions from mw.util directly.

Remove dependency on module 'mediawiki.user' for module
'ext.RevisionSlider.init' because this module uses only mw.user.options
which is generated in core module 'mediawiki' and not in
'mediawiki.user'.

Change-Id: Ifc6a20de667a410b9890fdc1fcba3319beb061de
---
M extension.json
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extension.json b/extension.json
index 7ee0604..c213517 100644
--- a/extension.json
+++ b/extension.json
@@ -74,7 +74,6 @@
                                "ext.RevisionSlider.Api",
                                "ext.RevisionSlider.icons",
                                "mediawiki.api.options",
-                               "mediawiki.user",
                                "mediawiki.util"
                        ],
                        "messages": [
@@ -170,7 +169,8 @@
                                "modules/ext.RevisionSlider.DiffPage.js"
                        ],
                        "dependencies": [
-                               "mediawiki.Uri"
+                               "mediawiki.Uri",
+                               "mediawiki.util"
                        ]
                },
                "ext.RevisionSlider.RevisionList": {
@@ -179,8 +179,7 @@
                        ],
                        "dependencies": [
                                "ext.RevisionSlider.Revision",
-                               "ext.RevisionSlider.RevisionListView",
-                               "mediawiki.util"
+                               "ext.RevisionSlider.RevisionListView"
                        ]
                },
                "ext.RevisionSlider.RevisionListView": {

-- 
To view, visit https://gerrit.wikimedia.org/r/374075
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc6a20de667a410b9890fdc1fcba3319beb061de
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Fomafix <foma...@googlemail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Andrew-WMDE <andrew.kos...@wikimedia.de>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: WMDE-Fisch <christoph.jau...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to