Yurik has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374125 )
Change subject: much faster tag filtering
......................................................................
much faster tag filtering
Change-Id: I657909e4f181748b10f200f33fcc702c412ee4e0
---
M wikibase/queryService/ui/QueryExampleDialog.js
1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui
refs/changes/25/374125/1
diff --git a/wikibase/queryService/ui/QueryExampleDialog.js
b/wikibase/queryService/ui/QueryExampleDialog.js
index 816cc34..c985859 100644
--- a/wikibase/queryService/ui/QueryExampleDialog.js
+++ b/wikibase/queryService/ui/QueryExampleDialog.js
@@ -194,20 +194,19 @@
* @private
*/
SELF.prototype._getCloudTags = function() {
- var self = this;
+ var self = this,
+ filterTags = self._$element.find( '.tagFilter'
).tags().getTags();
// filter tags that don't effect the filter for examples
var tagsFilter = function ( tags ) {
- var selectedTags = self._$element.find( '.tagFilter'
).tags().getTags();
-
- return selectedTags.every( function ( selectedTag ) {
+ return filterTags.every( function ( selectedTag ) {
return tags.indexOf( selectedTag.match(
/\((.*)\)/ )[1] ) !== -1;
} );
};
// filter selected tags from tag cloud
var tagFilter = function ( tag ) {
- var selectedTags = self._$element.find( '.tagFilter'
).tags().getTags().map(
+ var selectedTags = filterTags.map(
function ( v ) {
return v.match( /\((.*)\)/ )[1];
} );
--
To view, visit https://gerrit.wikimedia.org/r/374125
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I657909e4f181748b10f200f33fcc702c412ee4e0
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Yurik <yuriastrak...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
