jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/373900 )
Change subject: FocusableNode: Redraw highlights using focus toggle
......................................................................
FocusableNode: Redraw highlights using focus toggle
Bug: T129541
Change-Id: I7c176bdf9b6c10ae69a5398c6c0464203f61f497
---
M src/ce/ve.ce.FocusableNode.js
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
DLynch: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ce/ve.ce.FocusableNode.js b/src/ce/ve.ce.FocusableNode.js
index dd7663f..1594ac9 100644
--- a/src/ce/ve.ce.FocusableNode.js
+++ b/src/ce/ve.ce.FocusableNode.js
@@ -669,8 +669,12 @@
* @method
*/
ve.ce.FocusableNode.prototype.redrawHighlights = function () {
- this.clearHighlights();
- this.createHighlights();
+ if ( this.focused ) {
+ // setFocused will call clearHighlights/createHighlights
+ // and also re-bind events.
+ this.setFocused( false );
+ this.setFocused( true );
+ }
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/373900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c176bdf9b6c10ae69a5398c6c0464203f61f497
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: DLynch <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
