jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/373667 )
Change subject: Remove use of deprecated jQuery jqXHR `complete` method
......................................................................
Remove use of deprecated jQuery jqXHR `complete` method
An update to the mediawiki.org jQuery library to version 3.0, on which
the Zuul status page relies, caused a deprecation warning to be triggered,
which then broke the javascript that powers the Zuul status page because
the deprecation method logs using mw.log.deprecate(), which does not exist
on this page. We should use a separate copy of jQuery, but for now fix
the breakage by migrating the deprecated method call.
Bug: T174058
Change-Id: I4498e3b63d07d019db51b4f04a1dd20ebc7c1167
---
M zuul-status/public_html/jquery.zuul.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/zuul-status/public_html/jquery.zuul.js
b/zuul-status/public_html/jquery.zuul.js
index d973948..46c7785 100644
--- a/zuul-status/public_html/jquery.zuul.js
+++ b/zuul-status/public_html/jquery.zuul.js
@@ -625,7 +625,7 @@
setTimeout(function() {app.schedule(app);}, 5000);
return;
}
- app.update().complete(function () {
+ app.update().always(function () {
setTimeout(function() {app.schedule(app);}, 5000);
});
@@ -695,7 +695,7 @@
.removeClass('zuul-msg-wrap-off')
.show();
})
- .complete(function () {
+ .always(function () {
xhr = undefined;
app.emit('update-end');
});
--
To view, visit https://gerrit.wikimedia.org/r/373667
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4498e3b63d07d019db51b4f04a1dd20ebc7c1167
Gerrit-PatchSet: 2
Gerrit-Project: integration/docroot
Gerrit-Branch: master
Gerrit-Owner: Thcipriani <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Paladox <[email protected]>
Gerrit-Reviewer: Thcipriani <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
