jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/374376 )
Change subject: Don't use ES6 Number.isNaN ...................................................................... Don't use ES6 Number.isNaN Number.isNaN is a new function introduced in ECMAScript 6. MediaWiki only requires ECMAScript 5 supports from browsers. Notably, Opera 12 does not have Number.isNaN. Instead, use the global isNaN function (which behaves the same except for non-numeric inputs). Change-Id: If436cd26b21ce0336dfbc37144f6226e7b948e5e --- M resources/dist/index.js M resources/dist/index.js.map M src/userSettings.js 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Pmiazga: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/374376 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If436cd26b21ce0336dfbc37144f6226e7b948e5e Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits