[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Make dbBatchSize in WikiPageUpdater configurable

[AnotherLadsgroup (Code Review)]

AnotherLadsgroup has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/374505 )

Change subject: Make dbBatchSize in WikiPageUpdater configurable
......................................................................

Make dbBatchSize in WikiPageUpdater configurable

Bug: T174422
Change-Id: I9eb228a3961ce8a3f0cd9e10337d3783771aff88
---
M client/config/WikibaseClient.default.php
M client/includes/Changes/WikiPageUpdater.php
M client/includes/WikibaseClient.php
3 files changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/05/374505/1

diff --git a/client/config/WikibaseClient.default.php 
b/client/config/WikibaseClient.default.php
index 6df21cf..415b531 100644
--- a/client/config/WikibaseClient.default.php
+++ b/client/config/WikibaseClient.default.php
@@ -97,6 +97,9 @@
                        return $settings->hasSetting( 'hasFullEntityIdColumn' ) 
?
                                $settings->getSetting( 'hasFullEntityIdColumn' 
) : true;
                },
+
+               // Database batch size in WikiPageUpdater which ChangeHandler 
uses
+               'wikiPageUpdaterDbBatchSize' => 50,
        ];
 
        // Some defaults depend on information not available at this time.
diff --git a/client/includes/Changes/WikiPageUpdater.php 
b/client/includes/Changes/WikiPageUpdater.php
index 2739bc9..679ecf4 100644
--- a/client/includes/Changes/WikiPageUpdater.php
+++ b/client/includes/Changes/WikiPageUpdater.php
@@ -10,6 +10,7 @@
 use Wikibase\Client\RecentChanges\RecentChangeFactory;
 use Wikibase\Client\RecentChanges\RecentChangesDuplicateDetector;
 use Wikibase\EntityChange;
+use Wikimedia\Assert\Assert;
 use Wikimedia\Rdbms\LBFactory;
 
 /**
@@ -85,6 +86,8 @@
         * @param int $dbBatchSize
         */
        public function setDbBatchSize( $dbBatchSize ) {
+               Assert::parameterType( 'integer', $dbBatchSize, 'dbBatchSize' );
+
                $this->dbBatchSize = $dbBatchSize;
        }
 
diff --git a/client/includes/WikibaseClient.php 
b/client/includes/WikibaseClient.php
index e237046..8a0427a 100644
--- a/client/includes/WikibaseClient.php
+++ b/client/includes/WikibaseClient.php
@@ -1211,6 +1211,8 @@
                        MediaWikiServices::getInstance()->getStatsdDataFactory()
                );
 
+               $pageUpdater->setDbBatchSize( $this->settings->getSetting( 
'wikiPageUpdaterDbBatchSize' ) );
+
                $changeListTransformer = new ChangeRunCoalescer(
                        $this->getStore()->getEntityRevisionLookup(),
                        $this->getEntityChangeFactory(),

-- 
To view, visit https://gerrit.wikimedia.org/r/374505
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9eb228a3961ce8a3f0cd9e10337d3783771aff88
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: AnotherLadsgroup <ladsgr...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits