Rush has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/374424 )

Change subject: openstack: remove legacy firewall rules for controller
......................................................................


openstack: remove legacy firewall rules for controller

* DNS has long been served from labservices*
* wikitech_ssh_public seems to serve no modern
  purpose and should not exist afaict.

Bug: T171494
Change-Id: Ib12427ac86915b08852d08cddb9a1b99b0324b8e
---
M modules/role/manifests/labs/openstack/nova/controller.pp
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Rush: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/role/manifests/labs/openstack/nova/controller.pp 
b/modules/role/manifests/labs/openstack/nova/controller.pp
index 28db88c..b9c829e 100644
--- a/modules/role/manifests/labs/openstack/nova/controller.pp
+++ b/modules/role/manifests/labs/openstack/nova/controller.pp
@@ -41,12 +41,6 @@
     $labs_networks = join($network::constants::labs_networks, ' ')
 
     $fwrules = {
-        wikitech_ssh_public => {
-            rule  => 'saddr (0.0.0.0/0) proto tcp dport (ssh) ACCEPT;',
-        },
-        dns_public => {
-            rule  => 'saddr (0.0.0.0/0) proto (udp tcp) dport 53 ACCEPT;',
-        },
         spice_consoles => {
             rule  => 'saddr (0.0.0.0/0) proto (udp tcp) dport 6082 ACCEPT;',
         },

-- 
To view, visit https://gerrit.wikimedia.org/r/374424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib12427ac86915b08852d08cddb9a1b99b0324b8e
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Rush <r...@wikimedia.org>
Gerrit-Reviewer: Andrew Bogott <abog...@wikimedia.org>
Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: Rush <r...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to