jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/372119 )
Change subject: Set $wgTranslatePermissionUrl to false doesn't remove "Request
permission" link
......................................................................
Set $wgTranslatePermissionUrl to false doesn't remove "Request permission" link
Even though $wgTranslatePermissionUrl was set to false, a link to Request
persmission was still displayed. The patch removes that link.
Bug: T56530
Change-Id: Id5322f44c6c11e8a651c7f82a3405e4eac798ae6
---
M resources/js/ext.translate.editor.js
1 file changed, 10 insertions(+), 7 deletions(-)
Approvals:
Brian Wolff: Looks good to me, but someone else must approve
D3r1ck01: Looks good to me, but someone else must approve
jenkins-bot: Verified
Nikerabbit: Checked; Looks good to me, approved
diff --git a/resources/js/ext.translate.editor.js
b/resources/js/ext.translate.editor.js
index e0a08bf..e4de848 100644
--- a/resources/js/ext.translate.editor.js
+++ b/resources/js/ext.translate.editor.js
@@ -771,19 +771,22 @@
$requestRight = $( '<span>' )
.addClass( 'tux-editor-request-right' )
- .text( mw.msg(
'translate-edit-nopermission' ) )
- .append( $( '<a>' )
+ .text( mw.msg(
'translate-edit-nopermission' ) );
+ // Make sure wgTranslatePermissionUrl setting
is not 'false'
+ if ( mw.config.get( 'wgTranslatePermissionUrl'
) !== false ) {
+ $requestRight
+ .append( $( '<a>' )
.text( mw.msg(
'translate-edit-askpermission' ) )
.addClass(
'tux-editor-ask-permission' )
.attr( {
href: mw.util.getUrl(
mw.config.get(
'wgTranslateUseSandbox' ) ?
-
'Special:TranslationStash' :
- mw.config.get(
'wgTranslatePermissionUrl' )
- )
+
'Special:TranslationStash' :
+
mw.config.get( 'wgTranslatePermissionUrl' )
+ )
} )
- );
-
+ );
+ }
// Disable the text area if user has no
translation rights.
// Use readonly to allow copy-pasting (except
for placeholders)
$textarea.prop( 'readonly', true );
--
To view, visit https://gerrit.wikimedia.org/r/372119
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5322f44c6c11e8a651c7f82a3405e4eac798ae6
Gerrit-PatchSet: 12
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: African Hope <[email protected]>
Gerrit-Reviewer: African Hope <[email protected]>
Gerrit-Reviewer: Brian Wolff <[email protected]>
Gerrit-Reviewer: D3r1ck01 <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
