jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/374853 )

Change subject: Only do one query for page ids in PageProps::getGoodIDs
......................................................................


Only do one query for page ids in PageProps::getGoodIDs

Change-Id: I0d1cff3173d54de0b8fadb5bf9766789ffe030a4
---
M includes/PageProps.php
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/PageProps.php b/includes/PageProps.php
index dac756e..ff8deee 100644
--- a/includes/PageProps.php
+++ b/includes/PageProps.php
@@ -242,6 +242,8 @@
        private function getGoodIDs( $titles ) {
                $result = [];
                if ( is_array( $titles ) ) {
+                       ( new LinkBatch( $titles ) )->execute();
+
                        foreach ( $titles as $title ) {
                                $pageID = $title->getArticleID();
                                if ( $pageID > 0 ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/374853
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0d1cff3173d54de0b8fadb5bf9766789ffe030a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Smalyshev <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to