Hello jenkins-bot, Tpt,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/374889
to review the following change.
Change subject: Revert "Avoids a stack overflow"
......................................................................
Revert "Avoids a stack overflow"
This reverts commit 6298f6598fe0680ad062c31be892db273d484526.
Change-Id: I0fc725f7710e2d806ecbdd4bcd07ec960f504395
---
M ProofreadPage.body.php
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage
refs/changes/89/374889/1
diff --git a/ProofreadPage.body.php b/ProofreadPage.body.php
index dbae3ab..56b01ed 100644
--- a/ProofreadPage.body.php
+++ b/ProofreadPage.body.php
@@ -25,7 +25,6 @@
use ProofreadPage\Page\PageContent;
use ProofreadPage\Page\PageContentBuilder;
use ProofreadPage\Pagination\PageNotInPaginationException;
-use ProofreadPage\ProofreadPageInit;
/*
@todo :
@@ -42,7 +41,7 @@
* @return int
*/
public static function getPageNamespaceId() {
- return ProofreadPageInit::getNamespaceId( 'page' );
+ return Context::getDefaultContext()->getPageNamespaceId();
}
/**
@@ -53,7 +52,7 @@
* @return int
*/
public static function getIndexNamespaceId() {
- return ProofreadPageInit::getNamespaceId( 'index' );
+ return Context::getDefaultContext()->getIndexNamespaceId();
}
/**
@@ -90,7 +89,6 @@
* @return bool if we have to continue the research for a content
handler
*/
public static function onContentHandlerDefaultModelFor( Title $title,
&$model ) {
- // Warning: do not use Context here because it assumes
ContentHandler is already initialized
if ( $title->inNamespace( self::getPageNamespaceId() ) ) {
$model = CONTENT_MODEL_PROOFREAD_PAGE;
return false;
--
To view, visit https://gerrit.wikimedia.org/r/374889
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fc725f7710e2d806ecbdd4bcd07ec960f504395
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: wmf/1.30.0-wmf.16
Gerrit-Owner: Thcipriani <[email protected]>
Gerrit-Reviewer: Tpt <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
