jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/374917 )
Change subject: Chore: use verb:noun for package scripts
......................................................................
Chore: use verb:noun for package scripts
Flip noun:verb for build and start NPM sub-scripts. This seems more
consistent with other scripts in the package.
Change-Id: I77ff5676e97d4674091393b1b3b364ba07694dc3
---
M package.json
M test/server/templates/page.test.ts
2 files changed, 7 insertions(+), 8 deletions(-)
Approvals:
Jhernandez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/package.json b/package.json
index 9b1b86d..580b676 100644
--- a/package.json
+++ b/package.json
@@ -4,9 +4,9 @@
"description": "An API driven skin for MediaWiki",
"scripts": {
"--- PRIMARY ---": "# Frequent user scripts.",
- "start": "npm-run-all --silent clean --parallel 'client:watch -- -d'
server:watch",
- "watch": "run-p -s start test:watch",
- "build": "NODE_ENV=production npm-run-all --silent clean --parallel
server:build 'client:build -- -p'",
+ "start": "npm-run-all --silent clean --parallel start:\\*",
+ "watch": "run-p -s start:\\* test:watch",
+ "build": "NODE_ENV=production npm-run-all --silent clean --parallel
build:\\*",
"format": "npm run -s lint -- --fix",
"lint": "eslint --cache --max-warnings 0 --ext ts,tsx,js,json .",
"test": "run-p -s lint build mocha",
@@ -17,10 +17,10 @@
"--- HOOKS ---": "# Triggered scripts.",
"precommit": "npm test -s",
"--- INTERNAL ---": "# Private scripts.",
- "server:watch": "nodemon -i dist -i src/client -e js,json,ts,tsx
${VERBOSE:--q} -x 'ts-node -P src/server src/server'",
- "server:build": "tsc -p src/server",
- "client:watch": "webpack-dev-server -w",
- "client:build": "webpack"
+ "start:server": "nodemon -i dist -i src/client -e js,json,ts,tsx
${VERBOSE:--q} -x 'ts-node -P src/server src/server'",
+ "start:client": "webpack-dev-server -dw",
+ "build:server": "tsc -p src/server",
+ "build:client": "webpack -p"
},
"repository": {
"type": "git",
diff --git a/test/server/templates/page.test.ts
b/test/server/templates/page.test.ts
index 4b0bb29..a993a22 100644
--- a/test/server/templates/page.test.ts
+++ b/test/server/templates/page.test.ts
@@ -1,4 +1,3 @@
-/* eslint-env mocha */
import * as assert from "assert";
import page from "../../../src/server/templates/page";
--
To view, visit https://gerrit.wikimedia.org/r/374917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77ff5676e97d4674091393b1b3b364ba07694dc3
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Sniedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
