jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/374992 )
Change subject: Make Minerva QUnit tests v2 compatible
......................................................................
Make Minerva QUnit tests v2 compatible
Drop the checks for number of assertions
Bug: T174598
Change-Id: I82728a389d733900144786c149239856562a8c46
---
M tests/qunit/skins.minerva.notifications.badge/test_NotificationBadge.js
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
jenkins-bot: Verified
Jdlrobson: Looks good to me, approved
diff --git
a/tests/qunit/skins.minerva.notifications.badge/test_NotificationBadge.js
b/tests/qunit/skins.minerva.notifications.badge/test_NotificationBadge.js
index 11961d1..9731762 100644
--- a/tests/qunit/skins.minerva.notifications.badge/test_NotificationBadge.js
+++ b/tests/qunit/skins.minerva.notifications.badge/test_NotificationBadge.js
@@ -9,7 +9,7 @@
}
} );
- QUnit.test( '#setCount', 2, function ( assert ) {
+ QUnit.test( '#setCount', function ( assert ) {
var initialClassExpectationsMet,
badge = new NotificationBadge( {
overlayManager: this.OverlayManager,
@@ -25,7 +25,7 @@
assert.ok( badge.$el.find( '.zero' ).length === 1, 'A zero
class is present on the badge' );
} );
- QUnit.test( '#render [hasUnseenNotifications]', 1, function ( assert ) {
+ QUnit.test( '#render [hasUnseenNotifications]', function ( assert ) {
var badge = new NotificationBadge( {
notificationCount: 0,
overlayManager: this.OverlayManager,
@@ -35,7 +35,7 @@
assert.ok( badge.$el.find( '.mw-ui-icon' ).length === 1, 'A
bell icon is visible' );
} );
- QUnit.test( '#markAsSeen', 2, function ( assert ) {
+ QUnit.test( '#markAsSeen', function ( assert ) {
var badge = new NotificationBadge( {
notificationCount: 2,
overlayManager: this.OverlayManager,
--
To view, visit https://gerrit.wikimedia.org/r/374992
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82728a389d733900144786c149239856562a8c46
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
