jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/374960 )
Change subject: More specific documentation for Snak[] arrays in DataAccess
......................................................................
More specific documentation for Snak[] arrays in DataAccess
Change-Id: I4e4abba5ab8180ab2d7c7f548792070aa15469d5
---
M client/includes/DataAccess/SnaksFinder.php
M client/includes/DataAccess/StatementTransclusionInteractor.php
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/client/includes/DataAccess/SnaksFinder.php
b/client/includes/DataAccess/SnaksFinder.php
index d6b7a3e..563ef4d 100644
--- a/client/includes/DataAccess/SnaksFinder.php
+++ b/client/includes/DataAccess/SnaksFinder.php
@@ -20,7 +20,7 @@
* @param PropertyId $propertyId The PropertyId for which we want the
formatted Snaks
* @param int[]|null $acceptableRanks
*
- * @return Snak[]
+ * @return Snak[] List of main snaks, all guaranteed to belong to the
same property ID.
*/
public function findSnaks(
StatementListProvider $statementListProvider,
diff --git a/client/includes/DataAccess/StatementTransclusionInteractor.php
b/client/includes/DataAccess/StatementTransclusionInteractor.php
index efdaf82..4707c7c 100644
--- a/client/includes/DataAccess/StatementTransclusionInteractor.php
+++ b/client/includes/DataAccess/StatementTransclusionInteractor.php
@@ -6,6 +6,7 @@
use Wikibase\Client\PropertyLabelNotResolvedException;
use Wikibase\Client\Usage\UsageAccumulator;
use Wikibase\DataModel\Entity\EntityId;
+use Wikibase\DataModel\Entity\PropertyId;
use Wikibase\DataModel\Services\Lookup\EntityLookup;
use Wikibase\DataModel\Snak\Snak;
use Wikibase\DataModel\Statement\StatementListProvider;
@@ -146,7 +147,7 @@
}
/**
- * @param Snak[] $snaks
+ * @param Snak[] $snaks List of main snaks, all guaranteed to belong to
the same property ID.
*
* @return string wikitext
*/
--
To view, visit https://gerrit.wikimedia.org/r/374960
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e4abba5ab8180ab2d7c7f548792070aa15469d5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
