Libraryupgrader has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375312 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.12.0
The following sniffs are failing and were disabled:
* MediaWiki.Files.ClassMatchesFilename.NotMatch
* MediaWiki.Files.ClassMatchesFilename.WrongCase
* MediaWiki.Files.OneClassPerFile.MultipleFound
Change-Id: I38ca043c1b987bd3753727f5f41b03e63a584f66
---
M composer.json
M includes/CampaignContent.php
M includes/UploadWizardTutorial.php
M phpcs.xml
4 files changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard
refs/changes/12/375312/1
diff --git a/composer.json b/composer.json
index d1e3215..daa26e1 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.11.0",
+ "mediawiki/mediawiki-codesniffer": "0.12.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/CampaignContent.php b/includes/CampaignContent.php
index 55e2727..c005cbc 100644
--- a/includes/CampaignContent.php
+++ b/includes/CampaignContent.php
@@ -22,7 +22,7 @@
* Checks user input JSON to make sure that it produces a valid
campaign object
*
* @throws JsonSchemaException: If invalid.
- * @return bool: True if valid.
+ * @return bool True if valid.
*/
function validate() {
$campaign = $this->getJsonData();
@@ -50,7 +50,7 @@
}
/**
- * @return bool: Whether content is valid JSON Schema.
+ * @return bool Whether content is valid JSON Schema.
*/
function isValid() {
try {
diff --git a/includes/UploadWizardTutorial.php
b/includes/UploadWizardTutorial.php
index cff075b..69b1121 100644
--- a/includes/UploadWizardTutorial.php
+++ b/includes/UploadWizardTutorial.php
@@ -86,7 +86,7 @@
/**
* Get tutorial file for a particular language, or false if not
available.
*
- * @param String $langCode: language Code
+ * @param String $langCode language Code
* @param String|null $campaign Upload Wizard campaign for which the
tutorial should be displayed.
*
* @return File|false
diff --git a/phpcs.xml b/phpcs.xml
index 69ff6a9..cd32665 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -7,6 +7,9 @@
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
<exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle"
/>
+ <exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
+ <exclude name="MediaWiki.Files.ClassMatchesFilename.WrongCase"
/>
+ <exclude name="MediaWiki.Files.OneClassPerFile.MultipleFound" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude
name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
--
To view, visit https://gerrit.wikimedia.org/r/375312
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38ca043c1b987bd3753727f5f41b03e63a584f66
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Libraryupgrader <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
