Libraryupgrader has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375336 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.12.0
The following sniffs are failing and were disabled:
* MediaWiki.Files.ClassMatchesFilename.NotMatch
* MediaWiki.Files.OneClassPerFile.MultipleFound
The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment.SpacingAfterParamType
* MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage
Change-Id: I0689ff20133a2a23d6389aa50487349c6ed3797b
---
M composer.json
M includes/skins/MenuBuilder.php
M includes/skins/MinervaTemplate.php
M includes/skins/SkinMinerva.php
M phpcs.xml
5 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue
refs/changes/36/375336/1
diff --git a/composer.json b/composer.json
index 55507be..daa26e1 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.10.1",
+ "mediawiki/mediawiki-codesniffer": "0.12.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/skins/MenuBuilder.php b/includes/skins/MenuBuilder.php
index 8d7b59c..9672912 100644
--- a/includes/skins/MenuBuilder.php
+++ b/includes/skins/MenuBuilder.php
@@ -39,7 +39,7 @@
* Insert an entry into the menu.
*
* @param string $name A unique name identifying the menu entry
- * @param bool [$isJSOnly] Whether the menu entry works without JS
+ * @param bool [ $isJSOnly] Whether the menu entry works without JS
* @throws DomainException When the entry already exists
* @return MenuEntry
*/
@@ -77,7 +77,7 @@
* @param string $targetName The name of the existing entry to insert
* the new entry after
* @param string $name The name of the new entry
- * @param bool [$isJSOnly] Whether the entry works without JS
+ * @param bool [ $isJSOnly] Whether the entry works without JS
* @throws DomainException When the existing entry doesn't exist
* @return MenuEntry
*/
@@ -148,9 +148,9 @@
*
* @param string $label
* @param string $url
- * @param string [$className] Any additional CSS classes that should
added to the output,
+ * @param string [ $className] Any additional CSS classes that should
added to the output,
* separated by spaces
- * @param array [$attrs] Additional data that can be associated with
the component
+ * @param array [ $attrs] Additional data that can be associated with
the component
*
* @return MenuEntry
*/
diff --git a/includes/skins/MinervaTemplate.php
b/includes/skins/MinervaTemplate.php
index 3062456..4e15ec9 100644
--- a/includes/skins/MinervaTemplate.php
+++ b/includes/skins/MinervaTemplate.php
@@ -213,7 +213,7 @@
$html .= $postHeadingHtml;
$html .= $data['subtitle'];
$html .= $internalBanner;
- $html .= '</div>';
+ $html .= '</div>';
}
return $html;
}
@@ -242,7 +242,7 @@
/**
* Gets the main menu only on Special:MobileMenu.
* On other pages the menu is rendered via JS.
- * @param array [$data] Data used to build the page
+ * @param array [ $data] Data used to build the page
* @return string
*/
protected function getMainMenuHtml( $data ) {
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index a1adbbd..ee57b5b 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -48,7 +48,7 @@
// If there's a custom site logo, use that instead of text
if ( isset( $customLogos['copyright'] ) ) {
- $attributes = [
+ $attributes = [
'src' => $customLogos['copyright'],
'alt' => $footerSitename,
];
@@ -231,7 +231,7 @@
$message = $this->msg( 'mobile-frontend-editor-edit'
)->inLanguage( $lang )->text();
$html = Html::openElement( 'span' );
$html .= Html::element( 'a', [
- 'href' => $this->getTitle()->getLocalUrl( [
'action' => 'edit', 'section' => $section ] ),
+ 'href' => $this->getTitle()->getLocalUrl( [
'action' => 'edit', 'section' => $section ] ),
'title' => $this->msg( 'editsectionhint',
$tooltip )->inLanguage( $lang )->text(),
'data-section' => $section,
// Note visibility of the edit section link
button is controlled by .edit-page in ui.less so
@@ -882,7 +882,7 @@
'title' => $this->msg(
'mobile-frontend-main-menu-button-tooltip' ),
'href' => $url,
'class' => MobileUI::iconClass( 'mainmenu',
'element', 'main-menu-button' ),
- 'id'=> 'mw-mf-main-menu-button',
+ 'id' => 'mw-mf-main-menu-button',
], $this->msg(
'mobile-frontend-main-menu-button-tooltip' ) )
);
}
diff --git a/phpcs.xml b/phpcs.xml
index 01ee7b1..a249e12 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -3,12 +3,12 @@
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName"/>
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment"/>
- <exclude
name="MediaWiki.Usage.ExtendClassUsage.FunctionVarUsage"/>
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag"/>
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment"/>
- <exclude
name="MediaWiki.Commenting.FunctionComment.WrongStyle"/>
+ <exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle"
/>
+ <exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
+ <exclude name="MediaWiki.Files.OneClassPerFile.MultipleFound" />
<exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch"/>
- <exclude
name="MediaWiki.Commenting.FunctionComment.SpacingAfterParamType"/>
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected"/>
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingReturn"/>
</rule>
--
To view, visit https://gerrit.wikimedia.org/r/375336
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0689ff20133a2a23d6389aa50487349c6ed3797b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Libraryupgrader <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
