jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/375194 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.12.0
The following sniffs are failing and were disabled:
* MediaWiki.Files.ClassMatchesFilename.NotMatch
* MediaWiki.Files.ClassMatchesFilename.WrongCase
* MediaWiki.Files.OneClassPerFile.MultipleFound
Change-Id: I74cbebfd3355cd0857917bb61a8048bdb16d6649
---
M FlaggedRevs.php
M backend/FlaggedRevision.php
M backend/FlaggedRevs.class.php
M backend/FlaggedRevsStats.php
M composer.json
M frontend/FlaggablePageView.php
M phpcs.xml
7 files changed, 14 insertions(+), 11 deletions(-)
Approvals:
Niharika29: Looks good to me, approved
jenkins-bot: Verified
diff --git a/FlaggedRevs.php b/FlaggedRevs.php
index c74bb3f..bcd048d 100644
--- a/FlaggedRevs.php
+++ b/FlaggedRevs.php
@@ -140,7 +140,7 @@
'editComments' => 50, # number of manual edit summaries used
'userpageBytes' => 0, # size of userpage (use 0 to not require
a userpage)
'neverBlocked' => true, # username was never blocked before?
- 'maxRevertedEditRatio' => .03, # max fraction of edits reverted via
"rollback"/"undo"
+ 'maxRevertedEditRatio' => 0.03, # max fraction of edits reverted via
"rollback"/"undo"
];
# Define when users get to have their own edits auto-reviewed. Set to false to
disable.
diff --git a/backend/FlaggedRevision.php b/backend/FlaggedRevision.php
index 0ab0c9e..4c47092 100644
--- a/backend/FlaggedRevision.php
+++ b/backend/FlaggedRevision.php
@@ -529,7 +529,7 @@
}
/**
- * @return string, filename accosciated with this revision.
+ * @return string filename accosciated with this revision.
* This returns NULL for non-image page revisions.
*/
public function getFileName() {
@@ -537,7 +537,7 @@
}
/**
- * @return string, sha1 key accosciated with this revision.
+ * @return string sha1 key accosciated with this revision.
* This returns NULL for non-image page revisions.
*/
public function getFileSha1() {
@@ -545,7 +545,7 @@
}
/**
- * @return string, timestamp accosciated with this revision.
+ * @return string timestamp accosciated with this revision.
* This returns NULL for non-image page revisions.
*/
public function getFileTimestamp() {
diff --git a/backend/FlaggedRevs.class.php b/backend/FlaggedRevs.class.php
index 46fa460..36ef149 100644
--- a/backend/FlaggedRevs.class.php
+++ b/backend/FlaggedRevs.class.php
@@ -797,7 +797,7 @@
/**
* @param array $flags
- * @return bool, is this revision at basic review condition?
+ * @return bool is this revision at basic review condition?
*/
public static function isChecked( array $flags ) {
self::load();
@@ -806,7 +806,7 @@
/**
* @param array $flags
- * @return bool, is this revision at quality review condition?
+ * @return bool is this revision at quality review condition?
*/
public static function isQuality( array $flags ) {
self::load();
@@ -815,7 +815,7 @@
/**
* @param array $flags
- * @return bool, is this revision at pristine review condition?
+ * @return bool is this revision at pristine review condition?
*/
public static function isPristine( array $flags ) {
self::load();
diff --git a/backend/FlaggedRevsStats.php b/backend/FlaggedRevsStats.php
index 2136e64..1d46391 100644
--- a/backend/FlaggedRevsStats.php
+++ b/backend/FlaggedRevsStats.php
@@ -409,12 +409,12 @@
$aveRT = ( $secondsR + $secondsP ) / $sampleSize; //
sample mean
sort( $times ); // order smallest -> largest
// Sample median
- $rank = intval( round( count( $times ) / 2 + .5 ) - 1 );
+ $rank = intval( round( count( $times ) / 2 + 0.5 ) - 1
);
$medianRT = $times[$rank];
// Make percentile tabulation data
$doPercentiles = [ 35, 45, 55, 65, 75, 85, 90, 95 ];
foreach ( $doPercentiles as $percentile ) {
- $rank = intval( round( $percentile * count(
$times ) / 100 + .5 ) - 1 );
+ $rank = intval( round( $percentile * count(
$times ) / 100 + 0.5 ) - 1 );
$rPerTable[$percentile] = $times[$rank];
}
$result['average'] = $aveRT;
diff --git a/composer.json b/composer.json
index eff2a81..7898723 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.11.0",
+ "mediawiki/mediawiki-codesniffer": "0.12.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php
index c0fc93d..b67c4d0 100644
--- a/frontend/FlaggablePageView.php
+++ b/frontend/FlaggablePageView.php
@@ -780,7 +780,7 @@
* Get collapsible diff-to-stable html to add to the review notice as
needed
* @param FlaggedRevision $srev stable version
* @param bool $quality revision is quality
- * @return string, the html line (either "" or "<diff toggle><diff
div>")
+ * @return string the html line (either "" or "<diff toggle><diff div>")
*/
protected function getTopDiffToggle( FlaggedRevision $srev, $quality ) {
$reqUser = $this->getUser();
diff --git a/phpcs.xml b/phpcs.xml
index 1e52c60..e6856b2 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -8,6 +8,9 @@
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
<exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle"
/>
+ <exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
+ <exclude name="MediaWiki.Files.ClassMatchesFilename.WrongCase"
/>
+ <exclude name="MediaWiki.Files.OneClassPerFile.MultipleFound" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude
name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
--
To view, visit https://gerrit.wikimedia.org/r/375194
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74cbebfd3355cd0857917bb61a8048bdb16d6649
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Libraryupgrader <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Niharika29 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
