jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/375320 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.12.0
The following sniffs are failing and were disabled:
* MediaWiki.Files.ClassMatchesFilename.NotMatch
* MediaWiki.Files.OneClassPerFile.MultipleFound
Change-Id: Ifa5ebeb67dc041c0b06cfe7d9d5591de33e0c0ba
---
M composer.json
M includes/WikidataPageBanner.functions.php
M includes/WikidataPageBanner.hooks.php
M phpcs.xml
4 files changed, 13 insertions(+), 11 deletions(-)
Approvals:
Niharika29: Looks good to me, approved
jenkins-bot: Verified
diff --git a/composer.json b/composer.json
index 2ea7f35..b48b74b 100644
--- a/composer.json
+++ b/composer.json
@@ -12,7 +12,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.11.0",
+ "mediawiki/mediawiki-codesniffer": "0.12.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/WikidataPageBanner.functions.php
b/includes/WikidataPageBanner.functions.php
index af686f5..ac6547d 100644
--- a/includes/WikidataPageBanner.functions.php
+++ b/includes/WikidataPageBanner.functions.php
@@ -227,7 +227,7 @@
* WikidataPageBanner::getStandardSizeUrls
* returns an array of urls of standard image sizes defined by
$wgWPBStandardSizes
*
- * @param String $filename Name of Image file
+ * @param String $filename Name of Image file
* @return array
*/
public static function getStandardSizeUrls( $filename ) {
@@ -247,8 +247,8 @@
/**
* Fetches a banner for a given title when none has been specified by
an editor
*
- * @param Title $title Title of the page
- * @return String|null file name of a suitable automatic banner or
null if none found
+ * @param Title $title Title of the page
+ * @return String|null file name of a suitable automatic banner or null
if none found
*/
public static function getAutomaticBanner( $title ) {
$config = self::getWPBConfig();
@@ -267,8 +267,8 @@
/**
* Fetches banner from PageImages
*
- * @param Title $title Title of the page
- * @return String|null file name of the banner found via page images
+ * @param Title $title Title of the page
+ * @return String|null file name of the banner found via page images
* or null if none found
*/
public static function getPageImagesBanner( $title ) {
@@ -288,8 +288,8 @@
/**
* WikidataPageBanner::getWikidataBanner Fetches banner from wikidata
for the specified page
*
- * @param Title $title Title of the page
- * @return String|null file name of the banner from wikidata
+ * @param Title $title Title of the page
+ * @return String|null file name of the banner from wikidata
* or null if none found
*/
public static function getWikidataBanner( $title ) {
diff --git a/includes/WikidataPageBanner.hooks.php
b/includes/WikidataPageBanner.hooks.php
index 00fa707..003a793 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -72,7 +72,7 @@
*
* @param OutputPage $out
* @param Skin $skin Skin object being rendered
- * @return bool
+ * @return bool
*/
public static function onBeforePageDisplay( OutputPage $out, Skin $skin
) {
$config = WikidataPageBannerFunctions::getWPBConfig();
@@ -138,8 +138,8 @@
* WikidataPageBanner::onOutputPageParserOutput add banner parameters
from ParserOutput to
* Output page
*
- * @param OutputPage $out
- * @param ParserOutput $pOut
+ * @param OutputPage $out
+ * @param ParserOutput $pOut
*/
public static function onOutputPageParserOutput( OutputPage $out,
ParserOutput $pOut ) {
if ( $pOut->getExtensionData( 'wpb-banner-options' ) !== null )
{
diff --git a/phpcs.xml b/phpcs.xml
index eac33ca..d66f3df 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -4,6 +4,8 @@
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
<exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
+ <exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
+ <exclude name="MediaWiki.Files.OneClassPerFile.MultipleFound" />
</rule>
<file>.</file>
<arg name="extensions" value="php" />
--
To view, visit https://gerrit.wikimedia.org/r/375320
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa5ebeb67dc041c0b06cfe7d9d5591de33e0c0ba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Libraryupgrader <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Niharika29 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
