jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/375289 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.12.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected
* MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.MissingReturn
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.Files.ClassMatchesFilename.NotMatch
The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment
Change-Id: I012f6101ad9b2a27fe3f29551bb7fad6c841090b
---
M SpamBlacklistHooks.php
M SpamBlacklist_body.php
M composer.json
M phpcs.xml
4 files changed, 25 insertions(+), 18 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/SpamBlacklistHooks.php b/SpamBlacklistHooks.php
index b3e3748..4b4d108 100644
--- a/SpamBlacklistHooks.php
+++ b/SpamBlacklistHooks.php
@@ -22,11 +22,11 @@
* Hook function for EditFilterMergedContent
*
* @param IContextSource $context
- * @param Content $content
- * @param Status $status
- * @param string $summary
- * @param User $user
- * @param bool $minoredit
+ * @param Content $content
+ * @param Status $status
+ * @param string $summary
+ * @param User $user
+ * @param bool $minoredit
*
* @return bool
*/
@@ -176,16 +176,16 @@
* Clear local spam blacklist caches on page save.
*
* @param Page $wikiPage
- * @param User $user
- * @param Content $content
- * @param string $summary
- * @param bool $isMinor
- * @param bool $isWatch
- * @param string $section
- * @param int $flags
+ * @param User $user
+ * @param Content $content
+ * @param string $summary
+ * @param bool $isMinor
+ * @param bool $isWatch
+ * @param string $section
+ * @param int $flags
* @param Revision|null $revision
- * @param Status $status
- * @param int $baseRevId
+ * @param Status $status
+ * @param int $baseRevId
*
* @return bool
*/
diff --git a/SpamBlacklist_body.php b/SpamBlacklist_body.php
index 40dda74..b3fb900 100644
--- a/SpamBlacklist_body.php
+++ b/SpamBlacklist_body.php
@@ -40,11 +40,11 @@
/**
* @param string[] $links An array of links to check against the
blacklist
- * @param Title $title The title of the page to which the filter shall
be applied.
+ * @param Title $title The title of the page to which the filter shall
be applied.
* This is used to load the old links already on the
page, so
* the filter is only applied to links that got added. If
not given,
* the filter is applied to all $links.
- * @param boolean $preventLog Whether to prevent logging of hits. Set
to true when
+ * @param bool $preventLog Whether to prevent logging of hits. Set to
true when
* the action is testing the links rather than attempting
to save them
* (e.g. the API spamblacklist action)
* @param string $mode Either 'check' or 'stash'
diff --git a/composer.json b/composer.json
index 3f63cbe..021a14c 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
- "mediawiki/mediawiki-codesniffer": "0.11.1"
+ "mediawiki/mediawiki-codesniffer": "0.12.0"
},
"scripts": {
"fix": "phpcbf",
diff --git a/phpcs.xml b/phpcs.xml
index 8139da0..2d89b6f 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,7 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
- <exclude name="MediaWiki.Commenting.FunctionComment"/>
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
+ <exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment"/>
</rule>
<rule ref="MediaWiki.NamingConventions.ValidGlobalName">
--
To view, visit https://gerrit.wikimedia.org/r/375289
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I012f6101ad9b2a27fe3f29551bb7fad6c841090b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SpamBlacklist
Gerrit-Branch: master
Gerrit-Owner: Libraryupgrader <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
