jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/375245 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.12.0
The following sniffs are failing and were disabled:
* MediaWiki.Files.ClassMatchesFilename.NotMatch
* MediaWiki.Files.ClassMatchesFilename.WrongCase
Change-Id: I4e569fbf4cb6743a3b548b7d5db73137786355c2
---
M OATHAuthUtils.php
M composer.json
M phpcs.xml
3 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/OATHAuthUtils.php b/OATHAuthUtils.php
index 07f2667..b9efbe0 100644
--- a/OATHAuthUtils.php
+++ b/OATHAuthUtils.php
@@ -22,7 +22,7 @@
* when storing the user's password in their session. We can use json
as the
* serialization format because $plaintextVars is an array of strings.
* @param array $plaintextVars array of user input strings
- * @param int $userId, passed to key derivation functions so each user
uses
+ * @param int $userId passed to key derivation functions so each user
uses
* distinct encryption and hmac keys
* @return string encrypted data packet
*/
diff --git a/composer.json b/composer.json
index 2b9d0e3..3fa0ae0 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.11.0",
+ "mediawiki/mediawiki-codesniffer": "0.12.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/phpcs.xml b/phpcs.xml
index 4917665..db152e8 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -5,6 +5,8 @@
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
<exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
+ <exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
+ <exclude name="MediaWiki.Files.ClassMatchesFilename.WrongCase"
/>
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
</rule>
--
To view, visit https://gerrit.wikimedia.org/r/375245
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e569fbf4cb6743a3b548b7d5db73137786355c2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OATHAuth
Gerrit-Branch: master
Gerrit-Owner: Libraryupgrader <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
