Dzahn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/54605


Change subject: puppet-lint: fix most "=> on line isn't properly aligned for 
resource", and all "unquoted file mode" and "ensure found on line but it's not 
the first attribute"
......................................................................

puppet-lint: fix most "=> on line isn't properly aligned for resource",
and all "unquoted file mode"
and "ensure found on line but it's not the first attribute"

Change-Id: I25da1eb7efed807dcfc6d8df272b1b475291f019
---
M manifests/misc/contint.pp
1 file changed, 12 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/05/54605/1

diff --git a/manifests/misc/contint.pp b/manifests/misc/contint.pp
index ab244c4..0a929b6 100644
--- a/manifests/misc/contint.pp
+++ b/manifests/misc/contint.pp
@@ -48,24 +48,24 @@
 
     file {
       '/var/lib/jenkins/.gitconfig':
-        mode => 0444,
-        owner => 'jenkins',
-        group => 'jenkins',
-        ensure => present,
-        source => 'puppet:///files/misc/jenkins/gitconfig',
+        ensure  => present,
+        mode    => '0444',
+        owner   => 'jenkins',
+        group   => 'jenkins',
+        source  => 'puppet:///files/misc/jenkins/gitconfig',
         require => User['jenkins'];
     }
 
     file {
       '/var/lib/jenkins/.git':
-        mode   => 2775,  # group sticky bit
-        group  => 'jenkins',
-        ensure => directory;
+        ensure => directory,
+        mode   => '2775',  # group sticky bit
+        group  => 'jenkins';
       '/var/lib/jenkins/bin':
-        owner => 'jenkins',
-        group => 'wikidev',
-        mode => 0775,
-        ensure => directory;
+        ensure => directory,
+        owner  => 'jenkins',
+        group  => 'wikidev',
+        mode   => '0775';
     }
 
   }

-- 
To view, visit https://gerrit.wikimedia.org/r/54605
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I25da1eb7efed807dcfc6d8df272b1b475291f019
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to