jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/375003 )
Change subject: EditPage: Remove unused variable in getCheckboxesOOUI()
......................................................................
EditPage: Remove unused variable in getCheckboxesOOUI()
This was unnecessarily copypasted from getCheckboxes().
The label's 'id' attribute is correctly being set below.
Change-Id: I1557461bfd16c22bb949e26d419e154f80c963d7
---
M includes/EditPage.php
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Huji: Looks good to me, but someone else must approve
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/includes/EditPage.php b/includes/EditPage.php
index 40913bb..664e9b8 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -4207,9 +4207,6 @@
if ( isset( $options['title-message'] ) ) {
$title = $this->context->msg(
$options['title-message'] )->text();
}
- if ( isset( $options['label-id'] ) ) {
- $labelAttribs['id'] = $options['label-id'];
- }
$checkboxes[ $legacyName ] = new OOUI\FieldLayout(
new OOUI\CheckboxInputWidget( [
--
To view, visit https://gerrit.wikimedia.org/r/375003
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1557461bfd16c22bb949e26d419e154f80c963d7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Huji <huji.h...@gmail.com>
Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Tpt <thoma...@hotmail.fr>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
