jenkins-bot has submitted this change and it was merged.
Change subject: Update afl_rev_id even if the edit summary changed
......................................................................
Update afl_rev_id even if the edit summary changed
(bug 28633) With $wgUseAutomaticEditSummaries=true, the edit summary is
different between EditFilterMerged and ArticleSaveComplete. AbuseFilter
was using edit summary changes to attempt to detect whether the two
hooks refer to the same edit. If it really is possible for multiple
edits to be performed in the same request, with arbitrary patterns of
EditFilterMerged and ArticleSaveComplete calls, then some more robust
method would be needed to match the hook calls. But I don't think that
is necessary at present.
Change-Id: I94321905f38eafde8add00eff73745af255c1f15
---
M AbuseFilter.hooks.php
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/AbuseFilter.hooks.php b/AbuseFilter.hooks.php
index fed4512..4690368 100644
--- a/AbuseFilter.hooks.php
+++ b/AbuseFilter.hooks.php
@@ -152,9 +152,8 @@
$vars = self::$successful_action_vars;
- if ( ( $vars->getVar('article_prefixedtext')->toString() !==
- $article->getTitle()->getPrefixedText() ) ||
- ( $vars->getVar('summary')->toString() !== $summary )
+ if ( $vars->getVar('article_prefixedtext')->toString() !==
+ $article->getTitle()->getPrefixedText()
) {
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/54620
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I94321905f38eafde8add00eff73745af255c1f15
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Tim Starling <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
