jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/375008 )

Change subject: Avoid !important in entityselector where not necessary
......................................................................


Avoid !important in entityselector where not necessary

Bug: T170531
Change-Id: I5f7ee8c0b443b8ebd26e5aa4195803d7891f3928
---
M 
view/resources/jquery/wikibase/themes/default/jquery.wikibase.entityselector.css
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Jonas Kress (WMDE): Looks good to me, but someone else must approve
  Ladsgroup: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/view/resources/jquery/wikibase/themes/default/jquery.wikibase.entityselector.css
 
b/view/resources/jquery/wikibase/themes/default/jquery.wikibase.entityselector.css
index 58d1c6f..30db6f5 100644
--- 
a/view/resources/jquery/wikibase/themes/default/jquery.wikibase.entityselector.css
+++ 
b/view/resources/jquery/wikibase/themes/default/jquery.wikibase.entityselector.css
@@ -70,12 +70,12 @@
        padding-right: 1.2em;
 }
 
-.ui-entityselector-input-recognized {
-       /* NOTE: !important because valueview styles */
-       border-color: #14866d !important;
+/* Specificity must be a little higher because of a valueview selector */
+.ui-entityselector-input.ui-entityselector-input-recognized {
+       border-color: #14866d;
 }
-.ui-entityselector-input-unrecognized {
-       /* NOTE: !important because valueview styles */
-       background-color: #fee7e6 !important;
-       border-color: #b32424 !important;
+
+.ui-entityselector-input.ui-entityselector-input-unrecognized {
+       background-color: #fee7e6;
+       border-color: #b32424;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/375008
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5f7ee8c0b443b8ebd26e5aa4195803d7891f3928
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Jakob <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to