Addshore has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/375811 )

Change subject: Use the same name for group an user in wmde stats
......................................................................

Use the same name for group an user in wmde stats

The graphite class currently only uses $user.
I think, at least right now, it makes sense to remove this
mild aditional compexity and just have the group be called the
same as $user (which is currently true)

Change-Id: I185590f138960054c7bb555264c2d321816b5c37
---
M modules/statistics/manifests/wmde.pp
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/11/375811/1

diff --git a/modules/statistics/manifests/wmde.pp 
b/modules/statistics/manifests/wmde.pp
index 82b4104..624b28c 100644
--- a/modules/statistics/manifests/wmde.pp
+++ b/modules/statistics/manifests/wmde.pp
@@ -7,8 +7,7 @@
     $statsd_host,
     $graphite_host,
     $wmde_secrets,
-    $user  = 'analytics-wmde',
-    $group = 'analytics-wmde',
+    $user  = 'analytics-wmde'
 ) {
 
     # The statistics module needs to be loaded before this one
@@ -18,7 +17,7 @@
 
     $homedir = "${statistics_working_path}/analytics-wmde"
 
-    group { $group:
+    group { $user:
         ensure => 'present',
         name   => $user,
     }
@@ -29,7 +28,7 @@
         managehome => false,
         home       => $homedir,
         system     => true,
-        require    => Group[$group],
+        require    => Group[$user],
     }
 
     # Scripts & crons that generate data for graphite

-- 
To view, visit https://gerrit.wikimedia.org/r/375811
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I185590f138960054c7bb555264c2d321816b5c37
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Addshore <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to