Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375826 )
Change subject: SpecialUpload: Stop loading 'mediawiki.action.edit'
......................................................................
SpecialUpload: Stop loading 'mediawiki.action.edit'
The comment says it's for <charinsert> support, but that's not true
anymore, as the CharInsert extension itself takes care of loading its
script on Special:Upload (see CharInsert::onBeforePageDisplay()).
Back in the day, this module included a lot more stuff related to the
edit toolbar and such, so this might have been warranted, but there is
nothing useful for uploading left in it anymore.
It's very unintuitive that it would be loaded there; folks did not
realize that it is the case and recent changes to the module started
causing issues on Special:Upload.
Bug: T174935
Change-Id: I11e886801a27f796e5a5935ec9c93b1329cc5b87
---
M includes/specials/SpecialUpload.php
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/26/375826/1
diff --git a/includes/specials/SpecialUpload.php
b/includes/specials/SpecialUpload.php
index 4cdc78f..d0eb8e3 100644
--- a/includes/specials/SpecialUpload.php
+++ b/includes/specials/SpecialUpload.php
@@ -1256,7 +1256,6 @@
$out->addJsConfigVars( $scriptVars );
$out->addModules( [
- 'mediawiki.action.edit', // For <charinsert> support
'mediawiki.special.upload', // Extras for thumbnail and
license preview.
] );
}
--
To view, visit https://gerrit.wikimedia.org/r/375826
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11e886801a27f796e5a5935ec9c93b1329cc5b87
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
