Matěj Suchánek has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375833 )
Change subject: Only preload grepping generator if possible
......................................................................
Only preload grepping generator if possible
When nopreload is True, preloading should always be allowed.
It isn't problem to move this filter after preloading since
it always needs the pages to have content to decide.
Change-Id: I9e4c30756660542c481521f985245e5d32ad02f5
---
M pywikibot/pagegenerators.py
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/33/375833/1
diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py
index a38d7d2..9551bb4 100644
--- a/pywikibot/pagegenerators.py
+++ b/pywikibot/pagegenerators.py
@@ -529,10 +529,6 @@
dupfiltergen = RegexFilterPageGenerator(
dupfiltergen, self.titlenotfilter_list, 'none')
- if self.articlefilter_list:
- dupfiltergen = RegexBodyFilterPageGenerator(
- PreloadingGenerator(dupfiltergen), self.articlefilter_list)
-
if self.catfilter_list:
dupfiltergen = CategoryFilterPageGenerator(
dupfiltergen, self.catfilter_list, self.site)
@@ -543,6 +539,12 @@
else:
dupfiltergen = PreloadingGenerator(dupfiltergen)
+ if self.articlefilter_list:
+ if not preload and not self.nopreload:
+ dupfiltergen = PreloadingGenerator(dupfiltergen)
+ dupfiltergen = RegexBodyFilterPageGenerator(
+ dupfiltergen, self.articlefilter_list)
+
return dupfiltergen
@deprecated_args(arg='category')
--
To view, visit https://gerrit.wikimedia.org/r/375833
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e4c30756660542c481521f985245e5d32ad02f5
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
