jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/375827 )
Change subject: Element: Improve error message when the widget being infused is
missing
......................................................................
Element: Improve error message when the widget being infused is missing
Bug: T174935
Change-Id: I4247c1c13127e3411c0440f14e742c6f80f5de05
---
M src/Element.js
1 file changed, 9 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, approved
diff --git a/src/Element.js b/src/Element.js
index 6c53497..21ca818 100644
--- a/src/Element.js
+++ b/src/Element.js
@@ -125,7 +125,7 @@
*/
OO.ui.Element.static.unsafeInfuse = function ( idOrNode, domPromise ) {
// look for a cached result of a previous infusion.
- var id, $elem, data, cls, parts, parent, obj, top, state,
infusedChildren;
+ var id, $elem, error, data, cls, parts, parent, obj, top, state,
infusedChildren;
if ( typeof idOrNode === 'string' ) {
id = idOrNode;
$elem = $( document.getElementById( id ) );
@@ -134,7 +134,14 @@
id = $elem.attr( 'id' );
}
if ( !$elem.length ) {
- throw new Error( 'Widget not found: ' + id );
+ if ( typeof idOrNode === 'string' ) {
+ error = 'Widget not found: ' + idOrNode;
+ } else if ( idOrNode && idOrNode.selector ) {
+ error = 'Widget not found: ' + idOrNode.selector;
+ } else {
+ error = 'Widget not found';
+ }
+ throw new Error( error );
}
if ( $elem[ 0 ].oouiInfused ) {
$elem = $elem[ 0 ].oouiInfused;
--
To view, visit https://gerrit.wikimedia.org/r/375827
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4247c1c13127e3411c0440f14e742c6f80f5de05
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
