jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/375854 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.12.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected
* MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic
* MediaWiki.Commenting.FunctionComment.MissingParamComment
Change-Id: Iaf7f195249987d0b8c0ab016507fbd05524cd9b1
---
M composer.json
M phpcs.xml
M src/TestingAccessWrapper.php
M tests/TestingAccessWrapperTest.php
M tests/WellProtectedParentClass.php
5 files changed, 6 insertions(+), 5 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/composer.json b/composer.json
index 765b359..102e183 100644
--- a/composer.json
+++ b/composer.json
@@ -32,7 +32,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.7.2",
+ "mediawiki/mediawiki-codesniffer": "0.12.0",
"phpunit/phpunit": "4.8.31"
},
"scripts": {
diff --git a/phpcs.xml b/phpcs.xml
index 06c43bc..4c3c745 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,6 +1,10 @@
<?xml version="1.0"?>
<ruleset>
- <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/>
+ <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
+ </rule>
<file>.</file>
<arg name="encoding" value="UTF-8"/>
<arg name="extensions" value="php"/>
diff --git a/src/TestingAccessWrapper.php b/src/TestingAccessWrapper.php
index 762df77..e86463f 100644
--- a/src/TestingAccessWrapper.php
+++ b/src/TestingAccessWrapper.php
@@ -152,4 +152,3 @@
return $propertyReflection;
}
}
-
diff --git a/tests/TestingAccessWrapperTest.php
b/tests/TestingAccessWrapperTest.php
index d0e27c8..e1732e3 100644
--- a/tests/TestingAccessWrapperTest.php
+++ b/tests/TestingAccessWrapperTest.php
@@ -125,4 +125,3 @@
}
}
-
diff --git a/tests/WellProtectedParentClass.php
b/tests/WellProtectedParentClass.php
index 05f267e..eb19d1b 100644
--- a/tests/WellProtectedParentClass.php
+++ b/tests/WellProtectedParentClass.php
@@ -17,4 +17,3 @@
return $this->privateParentProperty;
}
}
-
--
To view, visit https://gerrit.wikimedia.org/r/375854
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf7f195249987d0b8c0ab016507fbd05524cd9b1
Gerrit-PatchSet: 1
Gerrit-Project: testing-access-wrapper
Gerrit-Branch: master
Gerrit-Owner: Libraryupgrader <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
