jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/374995 )
Change subject: Add ReferenceContext implementation and tests
......................................................................
Add ReferenceContext implementation and tests
Similarly to QualifierContext, this is a context for a snak of a
reference of a statement, deriving from the abstract APIv2 context.
Bug: T168532
Change-Id: I329c31b64da871c2dddd6086478ea2ac3e039f53
---
A includes/ConstraintCheck/Context/ReferenceContext.php
A tests/phpunit/Context/ReferenceContextTest.php
2 files changed, 318 insertions(+), 0 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, approved
Jonas Kress (WMDE): Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/ConstraintCheck/Context/ReferenceContext.php
b/includes/ConstraintCheck/Context/ReferenceContext.php
new file mode 100644
index 0000000..bf93c8f
--- /dev/null
+++ b/includes/ConstraintCheck/Context/ReferenceContext.php
@@ -0,0 +1,86 @@
+<?php
+
+namespace WikibaseQuality\ConstraintReport\ConstraintCheck\Context;
+
+use Wikibase\DataModel\Entity\EntityDocument;
+use Wikibase\DataModel\Reference;
+use Wikibase\DataModel\Snak\Snak;
+use Wikibase\DataModel\Statement\Statement;
+
+/**
+ * A constraint check context for a snak of a reference of a statement.
+ */
+class ReferenceContext extends ApiV2Context {
+
+ /**
+ * @var Statement
+ */
+ private $statement;
+
+ /**
+ * @var Reference
+ */
+ private $reference;
+
+ public function __construct(
+ EntityDocument $entity,
+ Statement $statement,
+ Reference $reference,
+ Snak $snak
+ ) {
+ parent::__construct( $entity, $snak );
+ $this->statement = $statement;
+ $this->reference = $reference;
+ }
+
+ public function getType() {
+ return self::TYPE_REFERENCE;
+ }
+
+ protected function &getMainArray( array &$container ) {
+ $statementArray = &$this->getStatementArray(
+ $container,
+ $this->entity->getId()->getSerialization(),
+ $this->statement->getPropertyId()->getSerialization(),
+ $this->statement->getGuid()
+ );
+
+ if ( !array_key_exists( 'references', $statementArray ) ) {
+ $statementArray['references'] = [];
+ }
+ $referencesArray = &$statementArray['references'];
+
+ foreach ( $referencesArray as &$potentialReferenceArray ) {
+ if ( $potentialReferenceArray['hash'] ===
$this->reference->getHash() ) {
+ $referenceArray = &$potentialReferenceArray;
+ break;
+ }
+ }
+ if ( !isset( $referenceArray ) ) {
+ $referenceArray = [ 'hash' =>
$this->reference->getHash(), 'snaks' => [] ];
+ $referencesArray[] = &$referenceArray;
+ }
+
+ $snaksArray = &$referenceArray['snaks'];
+
+ $propertyId =
$this->getSnak()->getPropertyId()->getSerialization();
+ if ( !array_key_exists( $propertyId, $snaksArray ) ) {
+ $snaksArray[$propertyId] = [];
+ }
+ $propertyArray = &$snaksArray[$propertyId];
+
+ foreach ( $propertyArray as &$potentialSnakArray ) {
+ if ( $potentialSnakArray['hash'] ===
$this->getSnak()->getHash() ) {
+ $snakArray = &$potentialSnakArray;
+ break;
+ }
+ }
+ if ( !isset( $snakArray ) ) {
+ $snakArray = [ 'hash' => $this->getSnak()->getHash() ];
+ $propertyArray[] = &$snakArray;
+ }
+
+ return $snakArray;
+ }
+
+}
diff --git a/tests/phpunit/Context/ReferenceContextTest.php
b/tests/phpunit/Context/ReferenceContextTest.php
new file mode 100644
index 0000000..e2491d5
--- /dev/null
+++ b/tests/phpunit/Context/ReferenceContextTest.php
@@ -0,0 +1,232 @@
+<?php
+
+namespace WikibaseQuality\ConstraintReport\Test\Context;
+
+use Wikibase\DataModel\Reference;
+use Wikibase\DataModel\Statement\Statement;
+use Wikibase\Repo\Tests\NewItem;
+use Wikibase\Repo\Tests\NewStatement;
+use WikibaseQuality\ConstraintReport\ConstraintCheck\Context\Context;
+use WikibaseQuality\ConstraintReport\ConstraintCheck\Context\ReferenceContext;
+
+/**
+ * @covers
\WikibaseQuality\ConstraintReport\ConstraintCheck\Context\AbstractContext
+ * @covers
\WikibaseQuality\ConstraintReport\ConstraintCheck\Context\ApiV2Context
+ * @covers
\WikibaseQuality\ConstraintReport\ConstraintCheck\Context\ReferenceContext
+ * @uses \Wikibase\DataModel\Reference
+ * @uses \Wikibase\DataModel\Statement\Statement
+ * @uses \Wikibase\Repo\Tests\NewItem
+ * @uses \Wikibase\Repo\Tests\NewStatement
+ *
+ * @group WikibaseQualityConstraints
+ *
+ * @author Lucas Werkmeister
+ * @license GNU GPL v2+
+ */
+class ReferenceContextTest extends \PHPUnit_Framework_TestCase {
+
+ public function testGetSnak() {
+ $entity = NewItem::withId( 'Q1' )->build();
+ $statement = NewStatement::noValueFor( 'P1' )->build();
+ $snak = NewStatement::someValueFor( 'P2'
)->build()->getMainSnak();
+ $reference = new Reference( [ $snak ] );
+ $statement->getReferences()->addReference( $reference );
+ $context = new ReferenceContext( $entity, $statement,
$reference, $snak );
+
+ $this->assertSame( $snak, $context->getSnak() );
+ }
+
+ public function testGetEntity() {
+ $entity = NewItem::withId( 'Q1' )->build();
+ $statement = NewStatement::noValueFor( 'P1' )->build();
+ $snak = NewStatement::someValueFor( 'P2'
)->build()->getMainSnak();
+ $reference = new Reference( [ $snak ] );
+ $statement->getReferences()->addReference( $reference );
+ $context = new ReferenceContext( $entity, $statement,
$reference, $snak );
+
+ $this->assertSame( $entity, $context->getEntity() );
+ }
+
+ public function testGetType() {
+ $entity = NewItem::withId( 'Q1' )->build();
+ $statement = NewStatement::noValueFor( 'P1' )->build();
+ $snak = NewStatement::someValueFor( 'P2'
)->build()->getMainSnak();
+ $reference = new Reference( [ $snak ] );
+ $statement->getReferences()->addReference( $reference );
+ $context = new ReferenceContext( $entity, $statement,
$reference, $snak );
+
+ $this->assertSame( Context::TYPE_REFERENCE, $context->getType()
);
+ }
+
+ public function testGetSnakRank() {
+ $entity = NewItem::withId( 'Q1' )->build();
+ $rank = Statement::RANK_DEPRECATED;
+ $statement = NewStatement::noValueFor( 'P1' )
+ ->withRank( $rank )
+ ->build();
+ $snak = NewStatement::someValueFor( 'P2'
)->build()->getMainSnak();
+ $reference = new Reference( [ $snak ] );
+ $statement->getReferences()->addReference( $reference );
+ $context = new ReferenceContext( $entity, $statement,
$reference, $snak );
+
+ $this->assertSame( null, $context->getSnakRank() );
+ }
+
+ public function testGetSnakStatement() {
+ $entity = NewItem::withId( 'Q1' )->build();
+ $statement = NewStatement::noValueFor( 'P1' )->build();
+ $snak = NewStatement::someValueFor( 'P2'
)->build()->getMainSnak();
+ $reference = new Reference( [ $snak ] );
+ $statement->getReferences()->addReference( $reference );
+ $context = new ReferenceContext( $entity, $statement,
$reference, $snak );
+
+ $this->assertSame( null, $context->getSnakStatement() );
+ }
+
+ public function testStoreCheckResultInArray() {
+ $entity = NewItem::withId( 'Q1' )->build();
+ $statement1 = NewStatement::noValueFor( 'P1' )
+ ->withGuid( 'P1$13ea0742-0190-4d88-b7b0-baee67573818' )
+ ->build();
+ $statement2 = NewStatement::noValueFor( 'P1' )
+ ->withGuid( 'P1$9fbfae7f-6f21-4967-8e2c-ec04ca16873d' )
+ ->build();
+ $statement3 = NewStatement::noValueFor( 'P2' )
+ ->withGuid( 'P2$4638ca58-5128-4a1f-88a9-b379fe9f8ad9' )
+ ->build();
+ $snak1 = NewStatement::noValueFor( 'P11'
)->build()->getMainSnak();
+ $snak2 = NewStatement::someValueFor( 'P11'
)->build()->getMainSnak();
+ $snak3 = NewStatement::noValueFor( 'P12'
)->build()->getMainSnak();
+ $reference1 = new Reference( [ $snak1, $snak2, $snak3 ] );
+ $statement1->getReferences()->addReference( $reference1 );
+ $reference2 = new Reference( [ $snak2, $snak3 ] );
+ $statement1->getReferences()->addReference( $reference2 );
+ $statement2->getReferences()->addReference( $reference1 );
+ $statement3->getReferences()->addReference( $reference2 );
+ $context1 = new ReferenceContext( $entity, $statement1,
$reference1, $snak1 );
+ $context2 = new ReferenceContext( $entity, $statement1,
$reference1, $snak2 );
+ $context3 = new ReferenceContext( $entity, $statement1,
$reference1, $snak3 );
+ $context4 = new ReferenceContext( $entity, $statement1,
$reference2, $snak2 );
+ $context5 = new ReferenceContext( $entity, $statement1,
$reference2, $snak3 );
+ $context6 = new ReferenceContext( $entity, $statement2,
$reference1, $snak1 );
+ $context7 = new ReferenceContext( $entity, $statement3,
$reference2, $snak3 );
+ $result1 = [ 'result1' ];
+ $result2 = [ 'status' => 'some status', 'result' => 'second
result' ];
+ $result3 = [ 3 ];
+ $result4 = [ [ 'the fourth result' ] ];
+ $result5 = [ [ [ 5.0 ] ] ];
+
+ $actual = [];
+ $context1->storeCheckResultInArray( $result1, $actual );
+ $context2->storeCheckResultInArray( $result2, $actual );
+ $context3->storeCheckResultInArray( $result3, $actual );
+ $context3->storeCheckResultInArray( $result4, $actual );
+ $context4->storeCheckResultInArray( $result4, $actual );
+ $context5->storeCheckResultInArray( $result5, $actual );
+ $context6->storeCheckResultInArray( $result5, $actual );
+ $context7->storeCheckResultInArray( $result5, $actual );
+
+ $expected = [
+ 'Q1' => [
+ 'claims' => [
+ 'P1' => [
+ [
+ 'id' =>
'P1$13ea0742-0190-4d88-b7b0-baee67573818',
+ 'references' => [
+ [
+ 'hash'
=> $reference1->getHash(),
+ 'snaks'
=> [
+
'P11' => [
+
[
+
'hash' => $snak1->getHash(),
+
'results' => [
+
$result1,
+
]
+
],
+
[
+
'hash' => $snak2->getHash(),
+
'results' => [
+
$result2,
+
]
+
]
+
],
+
'P12' => [
+
[
+
'hash' => $snak3->getHash(),
+
'results' => [
+
$result3,
+
$result4,
+
]
+
]
+
]
+ ]
+ ],
+ [
+ 'hash'
=> $reference2->getHash(),
+ 'snaks'
=> [
+
'P11' => [
+
[
+
'hash' => $snak2->getHash(),
+
'results' => [
+
$result4,
+
]
+
]
+
],
+
'P12' => [
+
[
+
'hash' => $snak3->getHash(),
+
'results' => [
+
$result5,
+
]
+
]
+
]
+ ]
+ ],
+ ],
+ ],
+ [
+ 'id' =>
'P1$9fbfae7f-6f21-4967-8e2c-ec04ca16873d',
+ 'references' => [
+ [
+ 'hash'
=> $reference1->getHash(),
+ 'snaks'
=> [
+
'P11' => [
+
[
+
'hash' => $snak1->getHash(),
+
'results' => [
+
$result5,
+
]
+
],
+
],
+ ]
+ ],
+ ],
+ ],
+ ],
+ 'P2' => [
+ [
+ 'id' =>
'P2$4638ca58-5128-4a1f-88a9-b379fe9f8ad9',
+ 'references' => [
+ [
+ 'hash'
=> $reference2->getHash(),
+ 'snaks'
=> [
+
'P12' => [
+
[
+
'hash' => $snak3->getHash(),
+
'results' => [
+
$result5,
+
]
+
],
+
],
+ ]
+ ],
+ ],
+ ],
+ ],
+ ],
+ ],
+ ];
+ $this->assertSame( $expected, $actual );
+ }
+
+}
--
To view, visit https://gerrit.wikimedia.org/r/374995
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I329c31b64da871c2dddd6086478ea2ac3e039f53
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
