Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/376014 )
Change subject: Ensure only options belonging to the select widget can be
clicked
......................................................................
Ensure only options belonging to the select widget can be clicked
Change-Id: I91225e7a636fe15986d88559ce411f4c30746088
---
M src/widgets/SelectWidget.js
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/14/376014/1
diff --git a/src/widgets/SelectWidget.js b/src/widgets/SelectWidget.js
index cc6a700..976fa8a 100644
--- a/src/widgets/SelectWidget.js
+++ b/src/widgets/SelectWidget.js
@@ -508,7 +508,11 @@
* @return {OO.ui.OptionWidget|null} Outline item widget, `null` if none was
found
*/
OO.ui.SelectWidget.prototype.getTargetItem = function ( e ) {
- return $( e.target ).closest( '.oo-ui-optionWidget' ).data(
'oo-ui-optionWidget' ) || null;
+ var $option = $( e.target ).closest( '.oo-ui-optionWidget' );
+ if ( !$option.closest( '.oo-ui-selectWidget' ).is( this.$element ) ) {
+ return null;
+ }
+ return $option.data( 'oo-ui-optionWidget' ) || null;
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/376014
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91225e7a636fe15986d88559ce411f4c30746088
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
