jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/376082 )

Change subject: Fix tests
......................................................................


Fix tests

Iaa880531 added extra frames in the call stack, so the frame being
tested by the "setfenv invalid level" and "getfenv invalid level" tests
was no longer invalid.

Bug: T175065
Change-Id: Id1028e7c8bbb92fb9d7d01ebeabd94e8ba284b1c
---
M tests/phpunit/engines/LuaSandbox/SandboxTests.lua
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/phpunit/engines/LuaSandbox/SandboxTests.lua 
b/tests/phpunit/engines/LuaSandbox/SandboxTests.lua
index 78c746e..2ae5a56 100644
--- a/tests/phpunit/engines/LuaSandbox/SandboxTests.lua
+++ b/tests/phpunit/engines/LuaSandbox/SandboxTests.lua
@@ -1,11 +1,11 @@
 local testframework = require( 'Module:TestFramework' )
 
 local function setfenv1()
-       setfenv( 5, {} )
+       setfenv( 10, {} )
 end
 
 local function getfenv1()
-       assert( getfenv( 5 ) == nil )
+       assert( getfenv( 10 ) == nil )
 end
 
 return testframework.getTestProvider( {

-- 
To view, visit https://gerrit.wikimedia.org/r/376082
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id1028e7c8bbb92fb9d7d01ebeabd94e8ba284b1c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Anomie <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to