Jonas Kress (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376098 )
Change subject: Handle Query Helper exception gracefully ...................................................................... Handle Query Helper exception gracefully Catch exception and open editor in new window. Change-Id: I8130182b595e00fa0e522022aee3cda83ca0f7c4 --- M embed.html 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui refs/changes/98/376098/1 diff --git a/embed.html b/embed.html index bdf172a..bc1efa6 100644 --- a/embed.html +++ b/embed.html @@ -152,8 +152,8 @@ <div class="panel-body"> </div> </div> - <a class="link edit-link" target="_blank" data-i18n="[title]wdqs-embed-button-edit-query-title"><small data-i18n="wdqs-embed-button-edit-query"></small></a> - <a href="#" class="edit edit-link" data-toggle="popover"><span class="glyphicon glyphicon-pencil" aria-hidden="true"></span></a> + <a class="link edit-link" target="_blank" rel="noopener" data-i18n="[title]wdqs-embed-button-edit-query-title"><small data-i18n="wdqs-embed-button-edit-query"></small></a> + <a href="#" target="_blank" rel="noopener" class="edit edit-link" data-toggle="popover"><span class="glyphicon glyphicon-pencil" aria-hidden="true"></span></a> <!-- JS files --> <!-- build:js js/embed.vendor.min.js --> @@ -232,8 +232,12 @@ }, 1500 ) ); var $editor = $( '<div>' ); - qh.setQuery( query ); - qh.draw( $editor ); + try { + qh.setQuery( query ); + qh.draw( $editor ); + } catch ( e ) { + return; + } $('.edit').on('click',function(e){ e.preventDefault(); -- To view, visit https://gerrit.wikimedia.org/r/376098 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8130182b595e00fa0e522022aee3cda83ca0f7c4 Gerrit-PatchSet: 1 Gerrit-Project: wikidata/query/gui Gerrit-Branch: master Gerrit-Owner: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits