Ottomata has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/376395 )

Change subject: /etc/kafka/mirror should require confluent-kafka package
......................................................................

/etc/kafka/mirror should require confluent-kafka package

Also remove debug notify

Bug: T376379
Change-Id: I787e9e353d523f3686d66339c5969d6785aa277d
---
M modules/confluent/manifests/kafka/client.pp
M modules/role/manifests/kafka/jumbo/broker.pp
2 files changed, 1 insertion(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/95/376395/1

diff --git a/modules/confluent/manifests/kafka/client.pp 
b/modules/confluent/manifests/kafka/client.pp
index f1396d8..b861870 100644
--- a/modules/confluent/manifests/kafka/client.pp
+++ b/modules/confluent/manifests/kafka/client.pp
@@ -58,5 +58,6 @@
         recurse => true,
         purge   => true,
         force   => true,
+        require => Package[$package],
     }
 }
diff --git a/modules/role/manifests/kafka/jumbo/broker.pp 
b/modules/role/manifests/kafka/jumbo/broker.pp
index c200a54..59fcab5 100644
--- a/modules/role/manifests/kafka/jumbo/broker.pp
+++ b/modules/role/manifests/kafka/jumbo/broker.pp
@@ -11,9 +11,5 @@
         has_ganglia => false
     }
     include base::firewall
-
-    $kafka_cluster_name = 'jumbo'
-    $n = kafka_cluster_name($kafka_cluster_name)
-    notify { "kafka cluster name is given as ${kafka_cluster_name}, function 
returns ${n}": }
     include profile::kafka::broker
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/376395
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I787e9e353d523f3686d66339c5969d6785aa277d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata <ao...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to